language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-11-12 16:58:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[red-knot] treat annotated assignments without RHS in stubs as bindings (#16409)

Browse source
This commit is contained in:
Mike Perlov 2025-02-28 11:45:21 -05:00 • committed by GitHub
parent 5ca6cc2cc8
commit fdf0915283
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 80 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

7
crates/red_knot_python_semantic/src/semantic_index/definition.rs
View file

@ -515,7 +515,7 @@ impl DefinitionKind<'_> {
}
}
pub(crate) fn category(&self) -> DefinitionCategory {
pub(crate) fn category(&self, in_stub: bool) -> DefinitionCategory {
match self {
// functions, classes, and imports always bind, and we consider them declarations
DefinitionKind::Function(_)
@ -543,9 +543,10 @@ impl DefinitionKind<'_> {
DefinitionCategory::Binding
}
}
// annotated assignment is always a declaration, only a binding if there is a RHS
// Annotated assignment is always a declaration. It is also a binding if there is a RHS
// or if we are in a stub file. Unfortunately, it is common for stubs to omit even an `...` value placeholder.
DefinitionKind::AnnotatedAssignment(ann_assign) => {
if ann_assign.value.is_some() {
if in_stub || ann_assign.value.is_some() {
DefinitionCategory::DeclarationAndBinding
} else {
DefinitionCategory::Declaration