4 commits

Author	SHA1	Message	Date
InSync	f789b12705	[flake8-logging] Root logger calls (LOG015) (#14302)	2024-11-13 09:11:55 +00:00
Charlie Marsh	bc9b4571eb	Avoid failures due to non-deterministic binding ordering (#10478) ... ## Summary We're seeing failures in https://github.com/astral-sh/ruff/issues/10470 because `resolve_qualified_import_name` isn't guaranteed to return a specific import if a symbol is accessible in two ways (e.g., you have both `import logging` and `from logging import error` in scope, and you want `logging.error`). This PR breaks up the failing tests such that the imports aren't in the same scope. Closes https://github.com/astral-sh/ruff/issues/10470. ## Test Plan I added a `bindings.reverse()` to `resolve_qualified_import_name` to ensure that the tests pass regardless of the binding order.	2024-03-19 18:01:33 +00:00
qdegraaf	2aef46cb6f	Add Expr::Name checks to rules which use is_logger_candidate (#7521) ... ## Summary Expands several rules to also check for `Expr::Name` values. As they would previously not consider: ```python from logging import error error("foo") ``` as potential violations ```python import logging logging.error("foo") ``` as potential violations leading to inconsistent behaviour. The rules impacted are: - `BLE001` - `TRY400` - `TRY401` - `PLE1205` - `PLE1206` - `LOG007` - `G001`-`G004` - `G101` - `G201` - `G202` ## Test Plan Fixtures for all impacted rules expanded. ## Issue Link Refers: https://github.com/astral-sh/ruff/issues/7502	2023-09-27 00:21:22 +00:00
Charlie Marsh	5849a75223	Rename ruff crate to ruff_linter (#7529)	2023-09-20 08:38:27 +02:00