9 commits

Author	SHA1	Message	Date
Dan Parizher	46decd4feb	[pyupgrade] Fix UP008 to not apply when __class__ is a local variable (UP008) (#20497) ... ## Summary Fixes #20491	2025-09-23 10:56:39 -04:00
Dan Parizher	91995aa516	[pyupgrade] Fix false positive when class name is shadowed by local variable (UP008) (#20427) ... ## Summary Fixes #20422 --------- Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>	2025-09-18 14:05:05 +00:00
Igor Drokin	54df73c9f7	[pyupgrade] Apply UP008 only when the __class__ cell exists (#19424) ... ## Summary Resolves #19357 Skip UP008 diagnostic for `builtins.super(P, self)` calls when `__class__` is not referenced locally, preventing incorrect fixes. **Note:** I haven't found concrete information about which cases `__class__` will be loaded into the scope. Let me know if anyone has references, it would be useful to enhance the implementation. I did a lot of tests to determine when `__class__` is loaded. Considered sources: 1. [Python doc super](https://docs.python.org/3/library/functions.html#super) 2. [Python doc classes](https://docs.python.org/3/tutorial/classes.html) 3. [pep-3135](https://peps.python.org/pep-3135/#specification) As I understand it, Python will inject at runtime into local scope a `__class__` variable if it detects references to `super` or `__class__`. This allows calling `super()` and passing appropriate parameters. However, the compiler doesn't do the same for `builtins.super`, so we need to somehow introduce `__class__` into the local scope. I figured out `__class__` will be in scope with valid value when two conditions are met: 1. `super` or `__class__` names have been loaded within function scope 4. `__class__` is not overridden. I think my solution isn't elegant, so I would be appreciate a detailed review. ## Test Plan Added 19 test cases, updated snapshots. --------- Co-authored-by: Igor Drokin <drokinii1017@gmail.com>	2025-09-09 14:59:23 -04:00
Dan Parizher	221edcba5c	[pyupgrade] Keyword arguments in super should suppress the UP008 fix (#19131) ... ## Summary Fixes #19096	2025-07-09 15:13:22 -04:00
Robsdedude	a3638b3adc	[pyupgrade] Mark UP008 fix safe if no comments in range (#18683) ... <!-- Thank you for contributing to Ruff/ty! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? (Please prefix with `[ty]` for ty pull requests.) - Does this pull request include references to any relevant issues? --> ## Summary Mark `UP008`'s fix safe if it won't delete comments. ## Relevant Issues Fixes: https://github.com/astral-sh/ruff/issues/18533 --------- Co-authored-by: Brent Westbrook <36778786+ntBre@users.noreply.github.com>	2025-06-30 09:42:05 -04:00
Victor Hugo Gomes	cff5adf324	[pyupgrade] Suppress UP008 diagnostic if super symbol is not builtin (#18688) ... <!-- Thank you for contributing to Ruff/ty! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? (Please prefix with `[ty]` for ty pull requests.) - Does this pull request include references to any relevant issues? --> ## Summary Fixes #18684 <!-- What's the purpose of the change? What does it do, and why? --> ## Test Plan Add regression test <!-- How was it tested? -->	2025-06-16 15:09:31 -04:00
chiri	dbb0d60caa	[pyupgrade] Fix super(__class__, self) detection in UP008 (super-call-with-parameters) (#18478)	2025-06-12 08:52:45 +02:00
Charlie Marsh	998bfe0847	Avoid recommending no-argument super in slots=True dataclasses (#12530) ... ## Summary Closes https://github.com/astral-sh/ruff/issues/12506.	2024-07-26 10:09:51 -04:00
Charlie Marsh	5849a75223	Rename ruff crate to ruff_linter (#7529)	2023-09-20 08:38:27 +02:00

Renamed from crates/ruff/resources/test/fixtures/pyupgrade/UP008.py (Browse further)