mirror of
https://github.com/astral-sh/ruff.git
synced 2025-07-16 01:25:22 +00:00
c9dff5c7d5
## Summary Garbage collect ASTs once we are done checking a given file. Queries with a cross-file dependency on the AST will reparse the file on demand. This reduces ty's peak memory usage by ~20-30%. The primary change of this PR is adding a `node_index` field to every AST node, that is assigned by the parser. `ParsedModule` can use this to create a flat index of AST nodes any time the file is parsed (or reparsed). This allows `AstNodeRef` to simply index into the current instance of the `ParsedModule`, instead of storing a pointer directly. The indices are somewhat hackily (using an atomic integer) assigned by the `parsed_module` query instead of by the parser directly. Assigning the indices in source-order in the (recursive) parser turns out to be difficult, and collecting the nodes during semantic indexing is impossible as `SemanticIndex` does not hold onto a specific `ParsedModuleRef`, which the pointers in the flat AST are tied to. This means that we have to do an extra AST traversal to assign and collect the nodes into a flat index, but the small performance impact (~3% on cold runs) seems worth it for the memory savings. Part of https://github.com/astral-sh/ty/issues/214.
90 lines
3.6 KiB
Text
90 lines
3.6 KiB
Text
---
|
|
source: crates/ruff_python_parser/tests/fixtures.rs
|
|
input_file: crates/ruff_python_parser/resources/inline/err/star_slices.py
|
|
---
|
|
## AST
|
|
|
|
```
|
|
Module(
|
|
ModModule {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 0..19,
|
|
body: [
|
|
Expr(
|
|
StmtExpr {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 0..18,
|
|
value: Subscript(
|
|
ExprSubscript {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 0..18,
|
|
value: Name(
|
|
ExprName {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 0..5,
|
|
id: Name("array"),
|
|
ctx: Load,
|
|
},
|
|
),
|
|
slice: Slice(
|
|
ExprSlice {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 6..17,
|
|
lower: Some(
|
|
Starred(
|
|
ExprStarred {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 6..12,
|
|
value: Name(
|
|
ExprName {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 7..12,
|
|
id: Name("start"),
|
|
ctx: Load,
|
|
},
|
|
),
|
|
ctx: Load,
|
|
},
|
|
),
|
|
),
|
|
upper: Some(
|
|
Starred(
|
|
ExprStarred {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 13..17,
|
|
value: Name(
|
|
ExprName {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 14..17,
|
|
id: Name("end"),
|
|
ctx: Load,
|
|
},
|
|
),
|
|
ctx: Load,
|
|
},
|
|
),
|
|
),
|
|
step: None,
|
|
},
|
|
),
|
|
ctx: Load,
|
|
},
|
|
),
|
|
},
|
|
),
|
|
],
|
|
},
|
|
)
|
|
```
|
|
## Errors
|
|
|
|
|
|
|
1 | array[*start:*end]
|
|
| ^^^^^^ Syntax Error: Starred expression cannot be used here
|
|
|
|
|
|
|
|
|
|
|
|
1 | array[*start:*end]
|
|
| ^^^^ Syntax Error: Starred expression cannot be used here
|
|
|
|