Charlie Marsh 60132da7bb Add a NotebookError type to avoid returning Diagnostics on error (#7035) ... ## Summary This PR refactors the error-handling cases around Jupyter notebooks to use errors rather than `Box<Diagnostics>`, which creates some oddities in the downstream handling. So, instead of formatting errors as diagnostics _eagerly_ (in the notebook methods), we now return errors and convert those errors to diagnostics at the last possible moment (in `diagnostics.rs`). This is more ergonomic, as errors can be composed and reported-on in different ways, whereas diagnostics require a `Printer`, etc. See, e.g., https://github.com/astral-sh/ruff/pull/7013#discussion_r1311136301. ## Test Plan Ran `cargo run` over a Python file labeled with a `.ipynb` suffix, and saw: ``` foo.ipynb:1:1: E999 SyntaxError: Expected a Jupyter Notebook, which must be internally stored as JSON, but found a Python source file: expected value at line 1 column 1 ```		2023-09-01 11:08:05 +00:00
..
resources/test/fixtures	Include file permissions in key for cached files (#5901)	2023-07-25 17:06:47 +00:00
src	Add a NotebookError type to avoid returning Diagnostics on error (#7035)	2023-09-01 11:08:05 +00:00
tests	Respect .ipynb and .pyi sources when linting from stdin (#6628)	2023-08-16 20:33:59 +00:00
Cargo.toml	Add a --check flag to the formatter CLI (#6982)	2023-08-29 12:40:00 -04:00