mirror of
				https://github.com/astral-sh/ruff.git
				synced 2025-11-04 13:39:07 +00:00 
			
		
		
		
	## Summary Garbage collect ASTs once we are done checking a given file. Queries with a cross-file dependency on the AST will reparse the file on demand. This reduces ty's peak memory usage by ~20-30%. The primary change of this PR is adding a `node_index` field to every AST node, that is assigned by the parser. `ParsedModule` can use this to create a flat index of AST nodes any time the file is parsed (or reparsed). This allows `AstNodeRef` to simply index into the current instance of the `ParsedModule`, instead of storing a pointer directly. The indices are somewhat hackily (using an atomic integer) assigned by the `parsed_module` query instead of by the parser directly. Assigning the indices in source-order in the (recursive) parser turns out to be difficult, and collecting the nodes during semantic indexing is impossible as `SemanticIndex` does not hold onto a specific `ParsedModuleRef`, which the pointers in the flat AST are tied to. This means that we have to do an extra AST traversal to assign and collect the nodes into a flat index, but the small performance impact (~3% on cold runs) seems worth it for the memory savings. Part of https://github.com/astral-sh/ty/issues/214.
		
			
				
	
	
		
			533 lines
		
	
	
	
		
			24 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
			
		
		
	
	
			533 lines
		
	
	
	
		
			24 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
---
 | 
						|
source: crates/ruff_python_parser/tests/fixtures.rs
 | 
						|
input_file: crates/ruff_python_parser/resources/valid/statement/while.py
 | 
						|
---
 | 
						|
## AST
 | 
						|
 | 
						|
```
 | 
						|
Module(
 | 
						|
    ModModule {
 | 
						|
        node_index: AtomicNodeIndex(..),
 | 
						|
        range: 0..314,
 | 
						|
        body: [
 | 
						|
            While(
 | 
						|
                StmtWhile {
 | 
						|
                    node_index: AtomicNodeIndex(..),
 | 
						|
                    range: 0..16,
 | 
						|
                    test: Name(
 | 
						|
                        ExprName {
 | 
						|
                            node_index: AtomicNodeIndex(..),
 | 
						|
                            range: 6..7,
 | 
						|
                            id: Name("x"),
 | 
						|
                            ctx: Load,
 | 
						|
                        },
 | 
						|
                    ),
 | 
						|
                    body: [
 | 
						|
                        Expr(
 | 
						|
                            StmtExpr {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 13..16,
 | 
						|
                                value: EllipsisLiteral(
 | 
						|
                                    ExprEllipsisLiteral {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 13..16,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                    ],
 | 
						|
                    orelse: [],
 | 
						|
                },
 | 
						|
            ),
 | 
						|
            While(
 | 
						|
                StmtWhile {
 | 
						|
                    node_index: AtomicNodeIndex(..),
 | 
						|
                    range: 18..61,
 | 
						|
                    test: BoolOp(
 | 
						|
                        ExprBoolOp {
 | 
						|
                            node_index: AtomicNodeIndex(..),
 | 
						|
                            range: 24..37,
 | 
						|
                            op: And,
 | 
						|
                            values: [
 | 
						|
                                Compare(
 | 
						|
                                    ExprCompare {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 25..30,
 | 
						|
                                        left: Name(
 | 
						|
                                            ExprName {
 | 
						|
                                                node_index: AtomicNodeIndex(..),
 | 
						|
                                                range: 25..26,
 | 
						|
                                                id: Name("x"),
 | 
						|
                                                ctx: Load,
 | 
						|
                                            },
 | 
						|
                                        ),
 | 
						|
                                        ops: [
 | 
						|
                                            Gt,
 | 
						|
                                        ],
 | 
						|
                                        comparators: [
 | 
						|
                                            NumberLiteral(
 | 
						|
                                                ExprNumberLiteral {
 | 
						|
                                                    node_index: AtomicNodeIndex(..),
 | 
						|
                                                    range: 29..30,
 | 
						|
                                                    value: Int(
 | 
						|
                                                        1,
 | 
						|
                                                    ),
 | 
						|
                                                },
 | 
						|
                                            ),
 | 
						|
                                        ],
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                                Name(
 | 
						|
                                    ExprName {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 36..37,
 | 
						|
                                        id: Name("y"),
 | 
						|
                                        ctx: Load,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            ],
 | 
						|
                        },
 | 
						|
                    ),
 | 
						|
                    body: [
 | 
						|
                        Pass(
 | 
						|
                            StmtPass {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 43..47,
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                    ],
 | 
						|
                    orelse: [
 | 
						|
                        Expr(
 | 
						|
                            StmtExpr {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 58..61,
 | 
						|
                                value: EllipsisLiteral(
 | 
						|
                                    ExprEllipsisLiteral {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 58..61,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                    ],
 | 
						|
                },
 | 
						|
            ),
 | 
						|
            While(
 | 
						|
                StmtWhile {
 | 
						|
                    node_index: AtomicNodeIndex(..),
 | 
						|
                    range: 63..152,
 | 
						|
                    test: BoolOp(
 | 
						|
                        ExprBoolOp {
 | 
						|
                            node_index: AtomicNodeIndex(..),
 | 
						|
                            range: 69..76,
 | 
						|
                            op: And,
 | 
						|
                            values: [
 | 
						|
                                Name(
 | 
						|
                                    ExprName {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 69..70,
 | 
						|
                                        id: Name("x"),
 | 
						|
                                        ctx: Load,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                                Name(
 | 
						|
                                    ExprName {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 75..76,
 | 
						|
                                        id: Name("y"),
 | 
						|
                                        ctx: Load,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            ],
 | 
						|
                        },
 | 
						|
                    ),
 | 
						|
                    body: [
 | 
						|
                        Expr(
 | 
						|
                            StmtExpr {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 82..85,
 | 
						|
                                value: EllipsisLiteral(
 | 
						|
                                    ExprEllipsisLiteral {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 82..85,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                        Expr(
 | 
						|
                            StmtExpr {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 90..111,
 | 
						|
                                value: Call(
 | 
						|
                                    ExprCall {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 90..111,
 | 
						|
                                        func: Name(
 | 
						|
                                            ExprName {
 | 
						|
                                                node_index: AtomicNodeIndex(..),
 | 
						|
                                                range: 90..95,
 | 
						|
                                                id: Name("print"),
 | 
						|
                                                ctx: Load,
 | 
						|
                                            },
 | 
						|
                                        ),
 | 
						|
                                        arguments: Arguments {
 | 
						|
                                            range: 95..111,
 | 
						|
                                            node_index: AtomicNodeIndex(..),
 | 
						|
                                            args: [
 | 
						|
                                                StringLiteral(
 | 
						|
                                                    ExprStringLiteral {
 | 
						|
                                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                                        range: 96..110,
 | 
						|
                                                        value: StringLiteralValue {
 | 
						|
                                                            inner: Single(
 | 
						|
                                                                StringLiteral {
 | 
						|
                                                                    range: 96..110,
 | 
						|
                                                                    node_index: AtomicNodeIndex(..),
 | 
						|
                                                                    value: "Hello World!",
 | 
						|
                                                                    flags: StringLiteralFlags {
 | 
						|
                                                                        quote_style: Single,
 | 
						|
                                                                        prefix: Empty,
 | 
						|
                                                                        triple_quoted: false,
 | 
						|
                                                                    },
 | 
						|
                                                                },
 | 
						|
                                                            ),
 | 
						|
                                                        },
 | 
						|
                                                    },
 | 
						|
                                                ),
 | 
						|
                                            ],
 | 
						|
                                            keywords: [],
 | 
						|
                                        },
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                    ],
 | 
						|
                    orelse: [
 | 
						|
                        Expr(
 | 
						|
                            StmtExpr {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 123..144,
 | 
						|
                                value: Call(
 | 
						|
                                    ExprCall {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 123..144,
 | 
						|
                                        func: Name(
 | 
						|
                                            ExprName {
 | 
						|
                                                node_index: AtomicNodeIndex(..),
 | 
						|
                                                range: 123..128,
 | 
						|
                                                id: Name("print"),
 | 
						|
                                                ctx: Load,
 | 
						|
                                            },
 | 
						|
                                        ),
 | 
						|
                                        arguments: Arguments {
 | 
						|
                                            range: 128..144,
 | 
						|
                                            node_index: AtomicNodeIndex(..),
 | 
						|
                                            args: [
 | 
						|
                                                StringLiteral(
 | 
						|
                                                    ExprStringLiteral {
 | 
						|
                                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                                        range: 129..143,
 | 
						|
                                                        value: StringLiteralValue {
 | 
						|
                                                            inner: Single(
 | 
						|
                                                                StringLiteral {
 | 
						|
                                                                    range: 129..143,
 | 
						|
                                                                    node_index: AtomicNodeIndex(..),
 | 
						|
                                                                    value: "Olá, Mundo!",
 | 
						|
                                                                    flags: StringLiteralFlags {
 | 
						|
                                                                        quote_style: Single,
 | 
						|
                                                                        prefix: Empty,
 | 
						|
                                                                        triple_quoted: false,
 | 
						|
                                                                    },
 | 
						|
                                                                },
 | 
						|
                                                            ),
 | 
						|
                                                        },
 | 
						|
                                                    },
 | 
						|
                                                ),
 | 
						|
                                            ],
 | 
						|
                                            keywords: [],
 | 
						|
                                        },
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                        Expr(
 | 
						|
                            StmtExpr {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 149..152,
 | 
						|
                                value: EllipsisLiteral(
 | 
						|
                                    ExprEllipsisLiteral {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 149..152,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                    ],
 | 
						|
                },
 | 
						|
            ),
 | 
						|
            While(
 | 
						|
                StmtWhile {
 | 
						|
                    node_index: AtomicNodeIndex(..),
 | 
						|
                    range: 154..171,
 | 
						|
                    test: Named(
 | 
						|
                        ExprNamed {
 | 
						|
                            node_index: AtomicNodeIndex(..),
 | 
						|
                            range: 160..166,
 | 
						|
                            target: Name(
 | 
						|
                                ExprName {
 | 
						|
                                    node_index: AtomicNodeIndex(..),
 | 
						|
                                    range: 160..161,
 | 
						|
                                    id: Name("a"),
 | 
						|
                                    ctx: Store,
 | 
						|
                                },
 | 
						|
                            ),
 | 
						|
                            value: Name(
 | 
						|
                                ExprName {
 | 
						|
                                    node_index: AtomicNodeIndex(..),
 | 
						|
                                    range: 165..166,
 | 
						|
                                    id: Name("b"),
 | 
						|
                                    ctx: Load,
 | 
						|
                                },
 | 
						|
                            ),
 | 
						|
                        },
 | 
						|
                    ),
 | 
						|
                    body: [
 | 
						|
                        Expr(
 | 
						|
                            StmtExpr {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 168..171,
 | 
						|
                                value: EllipsisLiteral(
 | 
						|
                                    ExprEllipsisLiteral {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 168..171,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                    ],
 | 
						|
                    orelse: [],
 | 
						|
                },
 | 
						|
            ),
 | 
						|
            While(
 | 
						|
                StmtWhile {
 | 
						|
                    node_index: AtomicNodeIndex(..),
 | 
						|
                    range: 172..197,
 | 
						|
                    test: BoolOp(
 | 
						|
                        ExprBoolOp {
 | 
						|
                            node_index: AtomicNodeIndex(..),
 | 
						|
                            range: 178..192,
 | 
						|
                            op: And,
 | 
						|
                            values: [
 | 
						|
                                Named(
 | 
						|
                                    ExprNamed {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 179..185,
 | 
						|
                                        target: Name(
 | 
						|
                                            ExprName {
 | 
						|
                                                node_index: AtomicNodeIndex(..),
 | 
						|
                                                range: 179..180,
 | 
						|
                                                id: Name("a"),
 | 
						|
                                                ctx: Store,
 | 
						|
                                            },
 | 
						|
                                        ),
 | 
						|
                                        value: Name(
 | 
						|
                                            ExprName {
 | 
						|
                                                node_index: AtomicNodeIndex(..),
 | 
						|
                                                range: 184..185,
 | 
						|
                                                id: Name("b"),
 | 
						|
                                                ctx: Load,
 | 
						|
                                            },
 | 
						|
                                        ),
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                                Name(
 | 
						|
                                    ExprName {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 191..192,
 | 
						|
                                        id: Name("c"),
 | 
						|
                                        ctx: Load,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            ],
 | 
						|
                        },
 | 
						|
                    ),
 | 
						|
                    body: [
 | 
						|
                        Expr(
 | 
						|
                            StmtExpr {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 194..197,
 | 
						|
                                value: EllipsisLiteral(
 | 
						|
                                    ExprEllipsisLiteral {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 194..197,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                    ],
 | 
						|
                    orelse: [],
 | 
						|
                },
 | 
						|
            ),
 | 
						|
            While(
 | 
						|
                StmtWhile {
 | 
						|
                    node_index: AtomicNodeIndex(..),
 | 
						|
                    range: 198..220,
 | 
						|
                    test: Lambda(
 | 
						|
                        ExprLambda {
 | 
						|
                            node_index: AtomicNodeIndex(..),
 | 
						|
                            range: 204..215,
 | 
						|
                            parameters: Some(
 | 
						|
                                Parameters {
 | 
						|
                                    range: 211..212,
 | 
						|
                                    node_index: AtomicNodeIndex(
 | 
						|
                                        0,
 | 
						|
                                    ),
 | 
						|
                                    posonlyargs: [],
 | 
						|
                                    args: [
 | 
						|
                                        ParameterWithDefault {
 | 
						|
                                            range: 211..212,
 | 
						|
                                            node_index: AtomicNodeIndex(..),
 | 
						|
                                            parameter: Parameter {
 | 
						|
                                                range: 211..212,
 | 
						|
                                                node_index: AtomicNodeIndex(..),
 | 
						|
                                                name: Identifier {
 | 
						|
                                                    id: Name("x"),
 | 
						|
                                                    range: 211..212,
 | 
						|
                                                    node_index: AtomicNodeIndex(..),
 | 
						|
                                                },
 | 
						|
                                                annotation: None,
 | 
						|
                                            },
 | 
						|
                                            default: None,
 | 
						|
                                        },
 | 
						|
                                    ],
 | 
						|
                                    vararg: None,
 | 
						|
                                    kwonlyargs: [],
 | 
						|
                                    kwarg: None,
 | 
						|
                                },
 | 
						|
                            ),
 | 
						|
                            body: Name(
 | 
						|
                                ExprName {
 | 
						|
                                    node_index: AtomicNodeIndex(..),
 | 
						|
                                    range: 214..215,
 | 
						|
                                    id: Name("x"),
 | 
						|
                                    ctx: Load,
 | 
						|
                                },
 | 
						|
                            ),
 | 
						|
                        },
 | 
						|
                    ),
 | 
						|
                    body: [
 | 
						|
                        Expr(
 | 
						|
                            StmtExpr {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 217..220,
 | 
						|
                                value: EllipsisLiteral(
 | 
						|
                                    ExprEllipsisLiteral {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 217..220,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                    ],
 | 
						|
                    orelse: [],
 | 
						|
                },
 | 
						|
            ),
 | 
						|
            While(
 | 
						|
                StmtWhile {
 | 
						|
                    node_index: AtomicNodeIndex(..),
 | 
						|
                    range: 221..239,
 | 
						|
                    test: Await(
 | 
						|
                        ExprAwait {
 | 
						|
                            node_index: AtomicNodeIndex(..),
 | 
						|
                            range: 227..234,
 | 
						|
                            value: Name(
 | 
						|
                                ExprName {
 | 
						|
                                    node_index: AtomicNodeIndex(..),
 | 
						|
                                    range: 233..234,
 | 
						|
                                    id: Name("x"),
 | 
						|
                                    ctx: Load,
 | 
						|
                                },
 | 
						|
                            ),
 | 
						|
                        },
 | 
						|
                    ),
 | 
						|
                    body: [
 | 
						|
                        Expr(
 | 
						|
                            StmtExpr {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 236..239,
 | 
						|
                                value: EllipsisLiteral(
 | 
						|
                                    ExprEllipsisLiteral {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 236..239,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                    ],
 | 
						|
                    orelse: [],
 | 
						|
                },
 | 
						|
            ),
 | 
						|
            If(
 | 
						|
                StmtIf {
 | 
						|
                    node_index: AtomicNodeIndex(..),
 | 
						|
                    range: 241..313,
 | 
						|
                    test: BooleanLiteral(
 | 
						|
                        ExprBooleanLiteral {
 | 
						|
                            node_index: AtomicNodeIndex(..),
 | 
						|
                            range: 244..248,
 | 
						|
                            value: true,
 | 
						|
                        },
 | 
						|
                    ),
 | 
						|
                    body: [
 | 
						|
                        While(
 | 
						|
                            StmtWhile {
 | 
						|
                                node_index: AtomicNodeIndex(..),
 | 
						|
                                range: 254..298,
 | 
						|
                                test: Name(
 | 
						|
                                    ExprName {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 260..261,
 | 
						|
                                        id: Name("x"),
 | 
						|
                                        ctx: Load,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                                body: [
 | 
						|
                                    Pass(
 | 
						|
                                        StmtPass {
 | 
						|
                                            node_index: AtomicNodeIndex(..),
 | 
						|
                                            range: 271..275,
 | 
						|
                                        },
 | 
						|
                                    ),
 | 
						|
                                ],
 | 
						|
                                orelse: [
 | 
						|
                                    Pass(
 | 
						|
                                        StmtPass {
 | 
						|
                                            node_index: AtomicNodeIndex(..),
 | 
						|
                                            range: 294..298,
 | 
						|
                                        },
 | 
						|
                                    ),
 | 
						|
                                ],
 | 
						|
                            },
 | 
						|
                        ),
 | 
						|
                    ],
 | 
						|
                    elif_else_clauses: [
 | 
						|
                        ElifElseClause {
 | 
						|
                            range: 299..313,
 | 
						|
                            node_index: AtomicNodeIndex(..),
 | 
						|
                            test: None,
 | 
						|
                            body: [
 | 
						|
                                Pass(
 | 
						|
                                    StmtPass {
 | 
						|
                                        node_index: AtomicNodeIndex(..),
 | 
						|
                                        range: 309..313,
 | 
						|
                                    },
 | 
						|
                                ),
 | 
						|
                            ],
 | 
						|
                        },
 | 
						|
                    ],
 | 
						|
                },
 | 
						|
            ),
 | 
						|
        ],
 | 
						|
    },
 | 
						|
)
 | 
						|
```
 |