mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-30 22:01:47 +00:00
b28556d739
## Summary This PR updates the `E402` rule to work at cell level for Jupyter notebooks. This is enabled only in preview to gather feedback. The implementation basically resets the import boundary flag on the semantic model when we encounter the first statement in a cell. Another potential solution is to introduce `E403` rule that is specifically for notebooks that works at cell level while `E402` will be disabled for notebooks. ## Test Plan Add a notebook with imports in multiple cells and verify that the rule works as expected. resolves: #8669
92 lines
2.5 KiB
Rust
92 lines
2.5 KiB
Rust
use std::path::Path;
|
|
|
|
pub use expression::*;
|
|
pub use int::*;
|
|
pub use node::{AnyNode, AnyNodeRef, AstNode, NodeKind};
|
|
pub use nodes::*;
|
|
|
|
pub mod all;
|
|
pub mod call_path;
|
|
pub mod comparable;
|
|
pub mod docstrings;
|
|
mod expression;
|
|
pub mod hashable;
|
|
pub mod helpers;
|
|
pub mod identifier;
|
|
pub mod imports;
|
|
mod int;
|
|
mod node;
|
|
mod nodes;
|
|
pub mod parenthesize;
|
|
pub mod relocate;
|
|
pub mod statement_visitor;
|
|
pub mod stmt_if;
|
|
pub mod str;
|
|
pub mod traversal;
|
|
pub mod types;
|
|
pub mod visitor;
|
|
pub mod whitespace;
|
|
|
|
/// The type of a source file.
|
|
#[derive(Clone, Copy, Debug, PartialEq, is_macro::Is)]
|
|
pub enum SourceType {
|
|
/// The file contains Python source code.
|
|
Python(PySourceType),
|
|
/// The file contains TOML.
|
|
Toml(TomlSourceType),
|
|
}
|
|
|
|
impl Default for SourceType {
|
|
fn default() -> Self {
|
|
Self::Python(PySourceType::Python)
|
|
}
|
|
}
|
|
|
|
impl<P: AsRef<Path>> From<P> for SourceType {
|
|
fn from(path: P) -> Self {
|
|
match path.as_ref().file_name() {
|
|
Some(filename) if filename == "pyproject.toml" => Self::Toml(TomlSourceType::Pyproject),
|
|
Some(filename) if filename == "Pipfile" => Self::Toml(TomlSourceType::Pipfile),
|
|
Some(filename) if filename == "poetry.lock" => Self::Toml(TomlSourceType::Poetry),
|
|
_ => match path.as_ref().extension() {
|
|
Some(ext) if ext == "toml" => Self::Toml(TomlSourceType::Unrecognized),
|
|
_ => Self::Python(PySourceType::from(path)),
|
|
},
|
|
}
|
|
}
|
|
}
|
|
|
|
#[derive(Clone, Copy, Debug, PartialEq, is_macro::Is)]
|
|
pub enum TomlSourceType {
|
|
/// The source is a `pyproject.toml`.
|
|
Pyproject,
|
|
/// The source is a `Pipfile`.
|
|
Pipfile,
|
|
/// The source is a `poetry.lock`.
|
|
Poetry,
|
|
/// The source is an unrecognized TOML file.
|
|
Unrecognized,
|
|
}
|
|
|
|
#[derive(Clone, Copy, Debug, Default, PartialEq, Eq, is_macro::Is)]
|
|
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
|
|
pub enum PySourceType {
|
|
/// The source is a Python file (`.py`).
|
|
#[default]
|
|
Python,
|
|
/// The source is a Python stub file (`.pyi`).
|
|
Stub,
|
|
/// The source is a Jupyter notebook (`.ipynb`).
|
|
Ipynb,
|
|
}
|
|
|
|
impl<P: AsRef<Path>> From<P> for PySourceType {
|
|
fn from(path: P) -> Self {
|
|
match path.as_ref().extension() {
|
|
Some(ext) if ext == "py" => PySourceType::Python,
|
|
Some(ext) if ext == "pyi" => PySourceType::Stub,
|
|
Some(ext) if ext == "ipynb" => PySourceType::Ipynb,
|
|
_ => PySourceType::Python,
|
|
}
|
|
}
|
|
}
|