mirror of
				https://github.com/astral-sh/ruff.git
				synced 2025-10-31 03:55:09 +00:00 
			
		
		
		
	 13ffb5bc19
			
		
	
	
		13ffb5bc19
		
			
		
	
	
	
	
		
			
			(Supersedes #9152, authored by @LaBatata101) ## Summary This PR replaces the current parser generated from LALRPOP to a hand-written recursive descent parser. It also updates the grammar for [PEP 646](https://peps.python.org/pep-0646/) so that the parser outputs the correct AST. For example, in `data[*x]`, the index expression is now a tuple with a single starred expression instead of just a starred expression. Beyond the performance improvements, the parser is also error resilient and can provide better error messages. The behavior as seen by any downstream tools isn't changed. That is, the linter and formatter can still assume that the parser will _stop_ at the first syntax error. This will be updated in the following months. For more details about the change here, refer to the PR corresponding to the individual commits and the release blog post. ## Test Plan Write _lots_ and _lots_ of tests for both valid and invalid syntax and verify the output. ## Acknowledgements - @MichaReiser for reviewing 100+ parser PRs and continuously providing guidance throughout the project - @LaBatata101 for initiating the transition to a hand-written parser in #9152 - @addisoncrump for implementing the fuzzer which helped [catch](https://github.com/astral-sh/ruff/pull/10903) [a](https://github.com/astral-sh/ruff/pull/10910) [lot](https://github.com/astral-sh/ruff/pull/10966) [of](https://github.com/astral-sh/ruff/pull/10896) [bugs](https://github.com/astral-sh/ruff/pull/10877) --------- Co-authored-by: Victor Hugo Gomes <labatata101@linuxmail.org> Co-authored-by: Micha Reiser <micha@reiser.io>
		
			
				
	
	
		
			655 lines
		
	
	
	
		
			27 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
			
		
		
	
	
			655 lines
		
	
	
	
		
			27 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
| ---
 | |
| source: crates/ruff_python_parser/tests/fixtures.rs
 | |
| input_file: crates/ruff_python_parser/resources/valid/expressions/slice.py
 | |
| ---
 | |
| ## AST
 | |
| 
 | |
| ```
 | |
| Module(
 | |
|     ModModule {
 | |
|         range: 0..211,
 | |
|         body: [
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 23..27,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 23..27,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 23..24,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 25..26,
 | |
|                                     lower: None,
 | |
|                                     upper: None,
 | |
|                                     step: None,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 28..33,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 28..33,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 28..29,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 30..32,
 | |
|                                     lower: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 30..31,
 | |
|                                                 value: Int(
 | |
|                                                     1,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     upper: None,
 | |
|                                     step: None,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 34..39,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 34..39,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 34..35,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 36..38,
 | |
|                                     lower: None,
 | |
|                                     upper: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 37..38,
 | |
|                                                 value: Int(
 | |
|                                                     2,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     step: None,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 40..46,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 40..46,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 40..41,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 42..45,
 | |
|                                     lower: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 42..43,
 | |
|                                                 value: Int(
 | |
|                                                     1,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     upper: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 44..45,
 | |
|                                                 value: Int(
 | |
|                                                     2,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     step: None,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 47..52,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 47..52,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 47..48,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 49..51,
 | |
|                                     lower: None,
 | |
|                                     upper: None,
 | |
|                                     step: None,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 53..59,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 53..59,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 53..54,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 55..58,
 | |
|                                     lower: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 55..56,
 | |
|                                                 value: Int(
 | |
|                                                     1,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     upper: None,
 | |
|                                     step: None,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 60..66,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 60..66,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 60..61,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 62..65,
 | |
|                                     lower: None,
 | |
|                                     upper: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 63..64,
 | |
|                                                 value: Int(
 | |
|                                                     2,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     step: None,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 67..74,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 67..74,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 67..68,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 69..73,
 | |
|                                     lower: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 69..70,
 | |
|                                                 value: Int(
 | |
|                                                     1,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     upper: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 71..72,
 | |
|                                                 value: Int(
 | |
|                                                     2,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     step: None,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 75..81,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 75..81,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 75..76,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 77..80,
 | |
|                                     lower: None,
 | |
|                                     upper: None,
 | |
|                                     step: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 79..80,
 | |
|                                                 value: Int(
 | |
|                                                     3,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 82..89,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 82..89,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 82..83,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 84..88,
 | |
|                                     lower: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 84..85,
 | |
|                                                 value: Int(
 | |
|                                                     1,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     upper: None,
 | |
|                                     step: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 87..88,
 | |
|                                                 value: Int(
 | |
|                                                     3,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 90..97,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 90..97,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 90..91,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 92..96,
 | |
|                                     lower: None,
 | |
|                                     upper: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 93..94,
 | |
|                                                 value: Int(
 | |
|                                                     2,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     step: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 95..96,
 | |
|                                                 value: Int(
 | |
|                                                     3,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 98..106,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 98..106,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 98..99,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 100..105,
 | |
|                                     lower: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 100..101,
 | |
|                                                 value: Int(
 | |
|                                                     1,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     upper: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 102..103,
 | |
|                                                 value: Int(
 | |
|                                                     2,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     step: Some(
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 104..105,
 | |
|                                                 value: Int(
 | |
|                                                     3,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 127..136,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 127..136,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 127..128,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Named(
 | |
|                                 ExprNamed {
 | |
|                                     range: 129..135,
 | |
|                                     target: Name(
 | |
|                                         ExprName {
 | |
|                                             range: 129..130,
 | |
|                                             id: "y",
 | |
|                                             ctx: Store,
 | |
|                                         },
 | |
|                                     ),
 | |
|                                     value: NumberLiteral(
 | |
|                                         ExprNumberLiteral {
 | |
|                                             range: 134..135,
 | |
|                                             value: Int(
 | |
|                                                 2,
 | |
|                                             ),
 | |
|                                         },
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 137..149,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 137..149,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 137..138,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Slice(
 | |
|                                 ExprSlice {
 | |
|                                     range: 139..148,
 | |
|                                     lower: Some(
 | |
|                                         Named(
 | |
|                                             ExprNamed {
 | |
|                                                 range: 140..146,
 | |
|                                                 target: Name(
 | |
|                                                     ExprName {
 | |
|                                                         range: 140..141,
 | |
|                                                         id: "y",
 | |
|                                                         ctx: Store,
 | |
|                                                     },
 | |
|                                                 ),
 | |
|                                                 value: NumberLiteral(
 | |
|                                                     ExprNumberLiteral {
 | |
|                                                         range: 145..146,
 | |
|                                                         value: Int(
 | |
|                                                             2,
 | |
|                                                         ),
 | |
|                                                     },
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                     upper: None,
 | |
|                                     step: None,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 150..160,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 150..160,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 150..151,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Tuple(
 | |
|                                 ExprTuple {
 | |
|                                     range: 152..159,
 | |
|                                     elts: [
 | |
|                                         Named(
 | |
|                                             ExprNamed {
 | |
|                                                 range: 152..158,
 | |
|                                                 target: Name(
 | |
|                                                     ExprName {
 | |
|                                                         range: 152..153,
 | |
|                                                         id: "y",
 | |
|                                                         ctx: Store,
 | |
|                                                     },
 | |
|                                                 ),
 | |
|                                                 value: NumberLiteral(
 | |
|                                                     ExprNumberLiteral {
 | |
|                                                         range: 157..158,
 | |
|                                                         value: Int(
 | |
|                                                             2,
 | |
|                                                         ),
 | |
|                                                     },
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ],
 | |
|                                     ctx: Load,
 | |
|                                     parenthesized: false,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     range: 202..210,
 | |
|                     value: Subscript(
 | |
|                         ExprSubscript {
 | |
|                             range: 202..210,
 | |
|                             value: Name(
 | |
|                                 ExprName {
 | |
|                                     range: 202..203,
 | |
|                                     id: "x",
 | |
|                                     ctx: Load,
 | |
|                                 },
 | |
|                             ),
 | |
|                             slice: Tuple(
 | |
|                                 ExprTuple {
 | |
|                                     range: 204..209,
 | |
|                                     elts: [
 | |
|                                         NumberLiteral(
 | |
|                                             ExprNumberLiteral {
 | |
|                                                 range: 204..205,
 | |
|                                                 value: Int(
 | |
|                                                     1,
 | |
|                                                 ),
 | |
|                                             },
 | |
|                                         ),
 | |
|                                         Slice(
 | |
|                                             ExprSlice {
 | |
|                                                 range: 206..208,
 | |
|                                                 lower: None,
 | |
|                                                 upper: Some(
 | |
|                                                     NumberLiteral(
 | |
|                                                         ExprNumberLiteral {
 | |
|                                                             range: 207..208,
 | |
|                                                             value: Int(
 | |
|                                                                 2,
 | |
|                                                             ),
 | |
|                                                         },
 | |
|                                                     ),
 | |
|                                                 ),
 | |
|                                                 step: None,
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ],
 | |
|                                     ctx: Load,
 | |
|                                     parenthesized: false,
 | |
|                                 },
 | |
|                             ),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|         ],
 | |
|     },
 | |
| )
 | |
| ```
 |