mirror of
				https://github.com/astral-sh/ruff.git
				synced 2025-10-31 03:55:09 +00:00 
			
		
		
		
	 c9dff5c7d5
			
		
	
	
		c9dff5c7d5
		
			
		
	
	
	
	
		
			
			## Summary Garbage collect ASTs once we are done checking a given file. Queries with a cross-file dependency on the AST will reparse the file on demand. This reduces ty's peak memory usage by ~20-30%. The primary change of this PR is adding a `node_index` field to every AST node, that is assigned by the parser. `ParsedModule` can use this to create a flat index of AST nodes any time the file is parsed (or reparsed). This allows `AstNodeRef` to simply index into the current instance of the `ParsedModule`, instead of storing a pointer directly. The indices are somewhat hackily (using an atomic integer) assigned by the `parsed_module` query instead of by the parser directly. Assigning the indices in source-order in the (recursive) parser turns out to be difficult, and collecting the nodes during semantic indexing is impossible as `SemanticIndex` does not hold onto a specific `ParsedModuleRef`, which the pointers in the flat AST are tied to. This means that we have to do an extra AST traversal to assign and collect the nodes into a flat index, but the small performance impact (~3% on cold runs) seems worth it for the memory savings. Part of https://github.com/astral-sh/ty/issues/214.
		
			
				
	
	
		
			142 lines
		
	
	
	
		
			4.4 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
			
		
		
	
	
			142 lines
		
	
	
	
		
			4.4 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
| ---
 | |
| source: crates/ruff_python_parser/tests/fixtures.rs
 | |
| input_file: crates/ruff_python_parser/resources/valid/expressions/name.py
 | |
| ---
 | |
| ## AST
 | |
| 
 | |
| ```
 | |
| Module(
 | |
|     ModModule {
 | |
|         node_index: AtomicNodeIndex(..),
 | |
|         range: 0..76,
 | |
|         body: [
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 0..1,
 | |
|                     value: Name(
 | |
|                         ExprName {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 0..1,
 | |
|                             id: Name("_"),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 2..5,
 | |
|                     value: Name(
 | |
|                         ExprName {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 3..4,
 | |
|                             id: Name("_"),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 6..8,
 | |
|                     value: Name(
 | |
|                         ExprName {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 6..8,
 | |
|                             id: Name("__"),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 9..17,
 | |
|                     value: Name(
 | |
|                         ExprName {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 9..17,
 | |
|                             id: Name("__init__"),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 18..22,
 | |
|                     value: Name(
 | |
|                         ExprName {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 18..22,
 | |
|                             id: Name("name"),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 23..29,
 | |
|                     value: Name(
 | |
|                         ExprName {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 24..28,
 | |
|                             id: Name("name"),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 60..65,
 | |
|                     value: Name(
 | |
|                         ExprName {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 60..65,
 | |
|                             id: Name("match"),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 66..70,
 | |
|                     value: Name(
 | |
|                         ExprName {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 66..70,
 | |
|                             id: Name("case"),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 71..75,
 | |
|                     value: Name(
 | |
|                         ExprName {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 71..75,
 | |
|                             id: Name("type"),
 | |
|                             ctx: Load,
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|         ],
 | |
|     },
 | |
| )
 | |
| ```
 |