mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-08 01:21:06 +00:00

## Summary https://github.com/astral-sh/ty/issues/214 will require a couple invasive changes that I would like to get merged even before garbage collection is fully implemented (to avoid rebasing): - `ParsedModule` can no longer be dereferenced directly. Instead you need to load a `ParsedModuleRef` to access the AST, which requires a reference to the salsa database (as it may require re-parsing the AST if it was collected). - `AstNodeRef` can only be dereferenced with the `node` method, which takes a reference to the `ParsedModuleRef`. This allows us to encode the fact that ASTs do not live as long as the database and may be collected as soon a given instance of a `ParsedModuleRef` is dropped. There are a number of places where we currently merge the `'db` and `'ast` lifetimes, so this requires giving some types/functions two separate lifetime parameters.
144 lines
4.9 KiB
Rust
144 lines
4.9 KiB
Rust
use ruff_db::files::File;
|
|
use ruff_db::parsed::ParsedModuleRef;
|
|
use ruff_python_ast::{self as ast, AnyNodeRef};
|
|
use ruff_text_size::{Ranged, TextRange};
|
|
|
|
use crate::Db;
|
|
use crate::ast_node_ref::AstNodeRef;
|
|
use crate::semantic_index::ast_ids::{HasScopedExpressionId, ScopedExpressionId};
|
|
use crate::semantic_index::expression::Expression;
|
|
use crate::semantic_index::place::{FileScopeId, ScopeId};
|
|
|
|
/// This ingredient represents a single unpacking.
|
|
///
|
|
/// This is required to make use of salsa to cache the complete unpacking of multiple variables
|
|
/// involved. It allows us to:
|
|
/// 1. Avoid doing structural match multiple times for each definition
|
|
/// 2. Avoid highlighting the same error multiple times
|
|
///
|
|
/// ## Module-local type
|
|
/// This type should not be used as part of any cross-module API because
|
|
/// it holds a reference to the AST node. Range-offset changes
|
|
/// then propagate through all usages, and deserialization requires
|
|
/// reparsing the entire module.
|
|
///
|
|
/// E.g. don't use this type in:
|
|
///
|
|
/// * a return type of a cross-module query
|
|
/// * a field of a type that is a return type of a cross-module query
|
|
/// * an argument of a cross-module query
|
|
#[salsa::tracked(debug)]
|
|
pub(crate) struct Unpack<'db> {
|
|
pub(crate) file: File,
|
|
|
|
pub(crate) value_file_scope: FileScopeId,
|
|
|
|
pub(crate) target_file_scope: FileScopeId,
|
|
|
|
/// The target expression that is being unpacked. For example, in `(a, b) = (1, 2)`, the target
|
|
/// expression is `(a, b)`.
|
|
#[no_eq]
|
|
#[tracked]
|
|
#[returns(ref)]
|
|
pub(crate) _target: AstNodeRef<ast::Expr>,
|
|
|
|
/// The ingredient representing the value expression of the unpacking. For example, in
|
|
/// `(a, b) = (1, 2)`, the value expression is `(1, 2)`.
|
|
pub(crate) value: UnpackValue<'db>,
|
|
|
|
count: countme::Count<Unpack<'static>>,
|
|
}
|
|
|
|
impl<'db> Unpack<'db> {
|
|
pub(crate) fn target<'ast>(
|
|
self,
|
|
db: &'db dyn Db,
|
|
parsed: &'ast ParsedModuleRef,
|
|
) -> &'ast ast::Expr {
|
|
self._target(db).node(parsed)
|
|
}
|
|
|
|
/// Returns the scope in which the unpack value expression belongs.
|
|
///
|
|
/// The scope in which the target and value expression belongs to are usually the same
|
|
/// except in generator expressions and comprehensions (list/dict/set), where the value
|
|
/// expression of the first generator is evaluated in the outer scope, while the ones in the subsequent
|
|
/// generators are evaluated in the comprehension scope.
|
|
pub(crate) fn value_scope(self, db: &'db dyn Db) -> ScopeId<'db> {
|
|
self.value_file_scope(db).to_scope_id(db, self.file(db))
|
|
}
|
|
|
|
/// Returns the scope where the unpack target expression belongs to.
|
|
pub(crate) fn target_scope(self, db: &'db dyn Db) -> ScopeId<'db> {
|
|
self.target_file_scope(db).to_scope_id(db, self.file(db))
|
|
}
|
|
|
|
/// Returns the range of the unpack target expression.
|
|
pub(crate) fn range(self, db: &'db dyn Db, module: &ParsedModuleRef) -> TextRange {
|
|
self.target(db, module).range()
|
|
}
|
|
}
|
|
|
|
/// The expression that is being unpacked.
|
|
#[derive(Clone, Copy, Debug, Hash, salsa::Update)]
|
|
pub(crate) struct UnpackValue<'db> {
|
|
/// The kind of unpack expression
|
|
kind: UnpackKind,
|
|
/// The expression we are unpacking
|
|
expression: Expression<'db>,
|
|
}
|
|
|
|
impl<'db> UnpackValue<'db> {
|
|
pub(crate) fn new(kind: UnpackKind, expression: Expression<'db>) -> Self {
|
|
Self { kind, expression }
|
|
}
|
|
|
|
/// Returns the underlying [`Expression`] that is being unpacked.
|
|
pub(crate) const fn expression(self) -> Expression<'db> {
|
|
self.expression
|
|
}
|
|
|
|
/// Returns the [`ScopedExpressionId`] of the underlying expression.
|
|
pub(crate) fn scoped_expression_id(
|
|
self,
|
|
db: &'db dyn Db,
|
|
scope: ScopeId<'db>,
|
|
module: &ParsedModuleRef,
|
|
) -> ScopedExpressionId {
|
|
self.expression()
|
|
.node_ref(db, module)
|
|
.scoped_expression_id(db, scope)
|
|
}
|
|
|
|
/// Returns the expression as an [`AnyNodeRef`].
|
|
pub(crate) fn as_any_node_ref<'ast>(
|
|
self,
|
|
db: &'db dyn Db,
|
|
module: &'ast ParsedModuleRef,
|
|
) -> AnyNodeRef<'ast> {
|
|
self.expression().node_ref(db, module).into()
|
|
}
|
|
|
|
pub(crate) const fn kind(self) -> UnpackKind {
|
|
self.kind
|
|
}
|
|
}
|
|
|
|
#[derive(Clone, Copy, Debug, Hash, salsa::Update)]
|
|
pub(crate) enum UnpackKind {
|
|
/// An iterable expression like the one in a `for` loop or a comprehension.
|
|
Iterable,
|
|
/// An context manager expression like the one in a `with` statement.
|
|
ContextManager,
|
|
/// An expression that is being assigned to a target.
|
|
Assign,
|
|
}
|
|
|
|
/// The position of the target element in an unpacking.
|
|
#[derive(Clone, Copy, Debug, Hash, PartialEq, salsa::Update)]
|
|
pub(crate) enum UnpackPosition {
|
|
/// The target element is in the first position of the unpacking.
|
|
First,
|
|
/// The target element is in the position other than the first position of the unpacking.
|
|
Other,
|
|
}
|