mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-30 13:51:37 +00:00
c5adbf17da
## Summary I think the check included here does make sense, but I don't see why we would allow it if a value is provided for the attribute -- since, in that case, isn't it _not_ abstract? Closes: https://github.com/astral-sh/ruff/issues/11208.
142 lines
2.5 KiB
Python
142 lines
2.5 KiB
Python
"""
|
|
Should emit:
|
|
B024 - on lines 18, 71, 82, 87, 92, 141
|
|
"""
|
|
|
|
import abc
|
|
import abc as notabc
|
|
from abc import ABC, ABCMeta
|
|
from abc import abstractmethod, abstractproperty
|
|
from abc import abstractmethod as abstract
|
|
from abc import abstractmethod as abstractaoeuaoeuaoeu
|
|
from abc import abstractmethod as notabstract
|
|
from abc import abstractproperty as notabstract_property
|
|
|
|
import foo
|
|
|
|
|
|
class Base_1(ABC): # error
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class Base_2(ABC):
|
|
@abstractmethod
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class Base_3(ABC):
|
|
@abc.abstractmethod
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class Base_4(ABC):
|
|
@notabc.abstractmethod
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class Base_5(ABC):
|
|
@abstract
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class Base_6(ABC):
|
|
@abstractaoeuaoeuaoeu
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class Base_7(ABC):
|
|
@notabstract
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class Base_8(ABC):
|
|
@notabstract_property
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class Base_9(ABC):
|
|
@abstractproperty
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class MetaBase_1(metaclass=ABCMeta): # error
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class MetaBase_2(metaclass=ABCMeta):
|
|
@abstractmethod
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class abc_Base_1(abc.ABC): # error
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class abc_Base_2(metaclass=abc.ABCMeta): # error
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class notabc_Base_1(notabc.ABC): # error
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class multi_super_1(notabc.ABC, abc.ABCMeta): # safe
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class multi_super_2(notabc.ABC, metaclass=abc.ABCMeta): # safe
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class non_keyword_abcmeta_1(ABCMeta): # safe
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class non_keyword_abcmeta_2(abc.ABCMeta): # safe
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
# very invalid code, but that's up to mypy et al to check
|
|
class keyword_abc_1(metaclass=ABC): # incorrect but outside scope of this check
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class keyword_abc_2(metaclass=abc.ABC): # incorrect but outside scope of this check
|
|
def method(self):
|
|
foo()
|
|
|
|
|
|
class abc_set_class_variable_1(ABC): # safe (abstract attribute)
|
|
foo: int
|
|
|
|
|
|
class abc_set_class_variable_2(ABC): # error (not an abstract attribute)
|
|
foo = 2
|
|
|
|
|
|
class abc_set_class_variable_3(ABC): # error (not an abstract attribute)
|
|
foo: int = 2
|
|
|
|
|
|
# this doesn't actually declare a class variable, it's just an expression
|
|
class abc_set_class_variable_4(ABC): # error
|
|
foo
|