mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-31 12:05:57 +00:00
c9dff5c7d5
## Summary Garbage collect ASTs once we are done checking a given file. Queries with a cross-file dependency on the AST will reparse the file on demand. This reduces ty's peak memory usage by ~20-30%. The primary change of this PR is adding a `node_index` field to every AST node, that is assigned by the parser. `ParsedModule` can use this to create a flat index of AST nodes any time the file is parsed (or reparsed). This allows `AstNodeRef` to simply index into the current instance of the `ParsedModule`, instead of storing a pointer directly. The indices are somewhat hackily (using an atomic integer) assigned by the `parsed_module` query instead of by the parser directly. Assigning the indices in source-order in the (recursive) parser turns out to be difficult, and collecting the nodes during semantic indexing is impossible as `SemanticIndex` does not hold onto a specific `ParsedModuleRef`, which the pointers in the flat AST are tied to. This means that we have to do an extra AST traversal to assign and collect the nodes into a flat index, but the small performance impact (~3% on cold runs) seems worth it for the memory savings. Part of https://github.com/astral-sh/ty/issues/214.
80 lines
2.9 KiB
Text
80 lines
2.9 KiB
Text
---
|
|
source: crates/ruff_python_parser/tests/fixtures.rs
|
|
input_file: crates/ruff_python_parser/resources/inline/ok/nonlocal_stmt.py
|
|
---
|
|
## AST
|
|
|
|
```
|
|
Module(
|
|
ModModule {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 0..45,
|
|
body: [
|
|
FunctionDef(
|
|
StmtFunctionDef {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 0..44,
|
|
is_async: false,
|
|
decorator_list: [],
|
|
name: Identifier {
|
|
id: Name("_"),
|
|
range: 4..5,
|
|
node_index: AtomicNodeIndex(..),
|
|
},
|
|
type_params: None,
|
|
parameters: Parameters {
|
|
range: 5..7,
|
|
node_index: AtomicNodeIndex(
|
|
0,
|
|
),
|
|
posonlyargs: [],
|
|
args: [],
|
|
vararg: None,
|
|
kwonlyargs: [],
|
|
kwarg: None,
|
|
},
|
|
returns: None,
|
|
body: [
|
|
Nonlocal(
|
|
StmtNonlocal {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 13..23,
|
|
names: [
|
|
Identifier {
|
|
id: Name("x"),
|
|
range: 22..23,
|
|
node_index: AtomicNodeIndex(..),
|
|
},
|
|
],
|
|
},
|
|
),
|
|
Nonlocal(
|
|
StmtNonlocal {
|
|
node_index: AtomicNodeIndex(..),
|
|
range: 28..44,
|
|
names: [
|
|
Identifier {
|
|
id: Name("x"),
|
|
range: 37..38,
|
|
node_index: AtomicNodeIndex(..),
|
|
},
|
|
Identifier {
|
|
id: Name("y"),
|
|
range: 40..41,
|
|
node_index: AtomicNodeIndex(..),
|
|
},
|
|
Identifier {
|
|
id: Name("z"),
|
|
range: 43..44,
|
|
node_index: AtomicNodeIndex(..),
|
|
},
|
|
],
|
|
},
|
|
),
|
|
],
|
|
},
|
|
),
|
|
],
|
|
},
|
|
)
|
|
```
|