mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-27 04:19:18 +00:00
132 lines
5.3 KiB
Rust
132 lines
5.3 KiB
Rust
use ruff_formatter::{write, FormatRuleWithOptions};
|
|
use ruff_python_ast::{AnyNodeRef, AstNode};
|
|
use ruff_python_ast::{Expr, ExprSubscript};
|
|
|
|
use crate::expression::expr_tuple::TupleParentheses;
|
|
use crate::expression::parentheses::{
|
|
is_expression_parenthesized, parenthesized, NeedsParentheses, OptionalParentheses, Parentheses,
|
|
};
|
|
use crate::expression::CallChainLayout;
|
|
use crate::prelude::*;
|
|
use crate::preview::is_empty_parameters_no_unnecessary_parentheses_around_return_value_enabled;
|
|
|
|
#[derive(Default)]
|
|
pub struct FormatExprSubscript {
|
|
call_chain_layout: CallChainLayout,
|
|
}
|
|
|
|
impl FormatRuleWithOptions<ExprSubscript, PyFormatContext<'_>> for FormatExprSubscript {
|
|
type Options = CallChainLayout;
|
|
|
|
fn with_options(mut self, options: Self::Options) -> Self {
|
|
self.call_chain_layout = options;
|
|
self
|
|
}
|
|
}
|
|
|
|
impl FormatNodeRule<ExprSubscript> for FormatExprSubscript {
|
|
fn fmt_fields(&self, item: &ExprSubscript, f: &mut PyFormatter) -> FormatResult<()> {
|
|
let ExprSubscript {
|
|
range: _,
|
|
value,
|
|
slice,
|
|
ctx: _,
|
|
} = item;
|
|
|
|
let call_chain_layout = self.call_chain_layout.apply_in_node(item, f);
|
|
|
|
let comments = f.context().comments().clone();
|
|
let dangling_comments = comments.dangling(item.as_any_node_ref());
|
|
debug_assert!(
|
|
dangling_comments.len() <= 1,
|
|
"A subscript expression can only have a single dangling comment, the one after the bracket"
|
|
);
|
|
|
|
let format_inner = format_with(|f: &mut PyFormatter| {
|
|
if is_expression_parenthesized(
|
|
value.into(),
|
|
f.context().comments().ranges(),
|
|
f.context().source(),
|
|
) {
|
|
value.format().with_options(Parentheses::Always).fmt(f)
|
|
} else {
|
|
match value.as_ref() {
|
|
Expr::Attribute(expr) => expr.format().with_options(call_chain_layout).fmt(f),
|
|
Expr::Call(expr) => expr.format().with_options(call_chain_layout).fmt(f),
|
|
Expr::Subscript(expr) => expr.format().with_options(call_chain_layout).fmt(f),
|
|
_ => value.format().with_options(Parentheses::Never).fmt(f),
|
|
}
|
|
}?;
|
|
|
|
let format_slice = format_with(|f: &mut PyFormatter| {
|
|
if let Expr::Tuple(tuple) = slice.as_ref() {
|
|
write!(f, [tuple.format().with_options(TupleParentheses::Preserve)])
|
|
} else {
|
|
write!(f, [slice.format()])
|
|
}
|
|
});
|
|
|
|
parenthesized("[", &format_slice, "]")
|
|
.with_dangling_comments(dangling_comments)
|
|
.fmt(f)
|
|
});
|
|
|
|
let is_call_chain_root = self.call_chain_layout == CallChainLayout::Default
|
|
&& call_chain_layout == CallChainLayout::Fluent;
|
|
if is_call_chain_root {
|
|
write!(f, [group(&format_inner)])
|
|
} else {
|
|
write!(f, [format_inner])
|
|
}
|
|
}
|
|
}
|
|
|
|
impl NeedsParentheses for ExprSubscript {
|
|
fn needs_parentheses(
|
|
&self,
|
|
parent: AnyNodeRef,
|
|
context: &PyFormatContext,
|
|
) -> OptionalParentheses {
|
|
{
|
|
if CallChainLayout::from_expression(
|
|
self.into(),
|
|
context.comments().ranges(),
|
|
context.source(),
|
|
) == CallChainLayout::Fluent
|
|
{
|
|
OptionalParentheses::Multiline
|
|
} else if is_expression_parenthesized(
|
|
self.value.as_ref().into(),
|
|
context.comments().ranges(),
|
|
context.source(),
|
|
) {
|
|
OptionalParentheses::Never
|
|
} else {
|
|
match self.value.needs_parentheses(self.into(), context) {
|
|
OptionalParentheses::BestFit => {
|
|
if let Some(function) = parent.as_stmt_function_def() {
|
|
if function.returns.as_deref().is_some_and(|returns| {
|
|
AnyNodeRef::ptr_eq(returns.into(), self.into())
|
|
}) {
|
|
if is_empty_parameters_no_unnecessary_parentheses_around_return_value_enabled(context) &&
|
|
function.parameters.is_empty() && !context.comments().has(&*function.parameters) {
|
|
// Apply the `optional_parentheses` layout when the subscript
|
|
// is in a return type position of a function without parameters.
|
|
// This ensures the subscript is parenthesized if it has a very
|
|
// long name that goes over the line length limit.
|
|
return OptionalParentheses::Multiline
|
|
}
|
|
|
|
// Don't use the best fitting layout for return type annotation because it results in the
|
|
// return type expanding before the parameters.
|
|
return OptionalParentheses::Never;
|
|
}
|
|
}
|
|
OptionalParentheses::BestFit
|
|
}
|
|
parentheses => parentheses,
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|