mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-26 20:09:22 +00:00
646ff6497c
## Summary
This PR protects against code like:
```python
from typing import Optional
import bar # ruff: noqa
import baz
class Foo:
x: Optional[str] = None
```
In which the user wrote `# ruff: noqa` to ignore a specific error, not
realizing that it was a file-level exemption that thus turned off all
lint rules.
Specifically, if a `# ruff: noqa` directive is not at the start of a
line, we now ignore it and warn, since this is almost certainly a
mistake.
54 lines
1.7 KiB
Rust
54 lines
1.7 KiB
Rust
use crate::{Ranged, Stmt};
|
|
use ruff_text_size::{TextRange, TextSize};
|
|
|
|
use ruff_python_trivia::{
|
|
has_trailing_content, indentation_at_offset, is_python_whitespace, PythonWhitespace,
|
|
};
|
|
use ruff_source_file::{newlines::UniversalNewlineIterator, Locator};
|
|
|
|
/// Extract the leading indentation from a line.
|
|
#[inline]
|
|
pub fn indentation<'a, T>(locator: &'a Locator, located: &T) -> Option<&'a str>
|
|
where
|
|
T: Ranged,
|
|
{
|
|
indentation_at_offset(located.start(), locator)
|
|
}
|
|
|
|
/// Return the end offset at which the empty lines following a statement.
|
|
pub fn trailing_lines_end(stmt: &Stmt, locator: &Locator) -> TextSize {
|
|
let line_end = locator.full_line_end(stmt.end());
|
|
let rest = &locator.contents()[usize::from(line_end)..];
|
|
|
|
UniversalNewlineIterator::with_offset(rest, line_end)
|
|
.take_while(|line| line.trim_whitespace().is_empty())
|
|
.last()
|
|
.map_or(line_end, |line| line.full_end())
|
|
}
|
|
|
|
/// Return `true` if a `Stmt` appears to be part of a multi-statement line, with
|
|
/// other statements following it.
|
|
pub fn followed_by_multi_statement_line(stmt: &Stmt, locator: &Locator) -> bool {
|
|
has_trailing_content(stmt.end(), locator)
|
|
}
|
|
|
|
/// If a [`Ranged`] has a trailing comment, return the index of the hash.
|
|
pub fn trailing_comment_start_offset<T>(located: &T, locator: &Locator) -> Option<TextSize>
|
|
where
|
|
T: Ranged,
|
|
{
|
|
let line_end = locator.line_end(located.end());
|
|
|
|
let trailing = &locator.contents()[TextRange::new(located.end(), line_end)];
|
|
|
|
for (index, char) in trailing.char_indices() {
|
|
if char == '#' {
|
|
return TextSize::try_from(index).ok();
|
|
}
|
|
if !is_python_whitespace(char) {
|
|
return None;
|
|
}
|
|
}
|
|
|
|
None
|
|
}
|