mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-03 07:04:53 +00:00
![]() In the new diagnostic data model, we really should have a main diagnostic message *and* a primary span (with an optional message attached to it) for every diagnostic. In this commit, I try to make this true for the "revealed type" diagnostic. Instead of the annotation saying both "revealed type is" and also the revealed type itself, the annotation is now just the revealed type and the main diagnostic message is "Revealed type." I expect this may be controversial. I'm open to doing something different. I tried to avoid redundancy, but maybe this is a special case where we want the redundancy. I'm honestly not sure. I do *like* how it looks with this commit, but I'm not working with Red Knot's type checking daily, so my opinion doesn't count for much. This did also require some tweaking to concise diagnostic formatting in order to preserve the essential information. This commit doesn't update every relevant snapshot. Just a few. I split the rest out into the next commit. |
||
---|---|---|
.. | ||
src | ||
Cargo.toml |