ruff/crates/ty_python_semantic/resources at bab688b76cf6ef3aba9bf9b9ae7b04100d3ba64b - language-servers/ruff

mirror of https://github.com/astral-sh/ruff.git synced 2025-12-23 09:19:39 +00:00

History

Alex Waygood bab688b76c Some checks are pending CI / mkdocs (push) Waiting to run Details CI / Determine changes (push) Waiting to run Details CI / cargo fmt (push) Waiting to run Details CI / cargo clippy (push) Blocked by required conditions Details CI / cargo test (linux) (push) Blocked by required conditions Details CI / cargo test (linux, release) (push) Blocked by required conditions Details CI / cargo test (${{ github.repository == 'astral-sh/ruff' && 'depot-windows-2022-16' \|\| 'windows-latest' }}) (push) Blocked by required conditions Details CI / cargo test (macos-latest) (push) Blocked by required conditions Details CI / cargo test (wasm) (push) Blocked by required conditions Details CI / cargo build (msrv) (push) Blocked by required conditions Details CI / cargo fuzz build (push) Blocked by required conditions Details CI / fuzz parser (push) Blocked by required conditions Details CI / test scripts (push) Blocked by required conditions Details CI / ecosystem (push) Blocked by required conditions Details CI / Fuzz for new ty panics (push) Blocked by required conditions Details CI / cargo shear (push) Blocked by required conditions Details CI / ty completion evaluation (push) Blocked by required conditions Details CI / python package (push) Waiting to run Details CI / pre-commit (push) Waiting to run Details CI / formatter instabilities and black similarity (push) Blocked by required conditions Details CI / test ruff-lsp (push) Blocked by required conditions Details CI / check playground (push) Blocked by required conditions Details CI / benchmarks instrumented (ruff) (push) Blocked by required conditions Details CI / benchmarks instrumented (ty) (push) Blocked by required conditions Details CI / benchmarks walltime (medium\|multithreaded) (push) Blocked by required conditions Details CI / benchmarks walltime (small\|large) (push) Blocked by required conditions Details [ty Playground] Release / publish (push) Waiting to run Details [ty] Retain the function-like-ness of `Callable` types when binding `self` (#21614 ) ## Summary For something like this: ```py from typing import Callable def my_lossy_decorator(fn: Callable[..., int]) -> Callable[..., int]: return fn class MyClass: @my_lossy_decorator def method(self) -> int: return 42 ``` we will currently infer the type of `MyClass.method` as a function-like `Callable`, but we will infer the type of `MyClass().method` as a `Callable` that is _not_ function-like. That's because a `CallableType` currently "forgets" whether it was function-like or not during the `bound_self` transformation: `a57e291311/crates/ty_python_semantic/src/types.rs (L10985-L10987)` This seems incorrect, and it's quite different to what we do when binding the `self` parameter of `FunctionLiteral` types: `BoundMethod` types are all seen as subtypes of function-like `Callable` supertypes -- here's `BoundMethodType::into_callable_type`: `a57e291311/crates/ty_python_semantic/src/types.rs (L10844-L10860)` The bug here is also causing lots of false positives in the ecosystem report on https://github.com/astral-sh/ruff/pull/21611: a decorated method on a subclass is currently not seen as validly overriding an undecorated method with the same signature on a superclass, because the undecorated superclass method is seen as function-like after binding `self` whereas the decorated subclass method is not. Fixing the bug required adding a new API in `protocol_class.rs`, because it turns out that for our purposes in protocol subtyping/assignability, we really do want a callable type to forget its function-like-ness when binding `self`. I initially tried out this change without changing anything in `protocol_class.rs`. However, it resulted in many ecosystem false positives and new false positives on the typing conformance test suite. This is because it would mean that no protocol with a `__call__` method would ever be seen as a subtype of a `Callable` type, since the `__call__` method on the protocol would be seen as being function-like whereas the `Callable` type would not be seen as function-like. ## Test Plan Added an mdtest that fails on `main`		2025-11-24 21:14:03 +00:00
..
corpus	[ty] fix global symbol lookup from eager scopes (#21317 )	2025-11-12 10:15:51 -08:00
mdtest	[ty] Retain the function-like-ness of `Callable` types when binding `self` (#21614 )	2025-11-24 21:14:03 +00:00
primer	[ty] Add cycle handling to `lazy_default` (#20967 )	2025-10-23 10:05:08 +02:00
README.md	Rename Red Knot (#17820 )	2025-05-03 19:49:15 +02:00

README.md

Markdown files within the mdtest/ subdirectory are tests of type inference and type checking; executed by the tests/mdtest.rs integration test.

See crates/ty_test/README.md for documentation of this test format.