mirror of
				https://github.com/astral-sh/ruff.git
				synced 2025-10-30 19:47:52 +00:00 
			
		
		
		
	 c9dff5c7d5
			
		
	
	
		c9dff5c7d5
		
			
		
	
	
	
	
		
			
			## Summary Garbage collect ASTs once we are done checking a given file. Queries with a cross-file dependency on the AST will reparse the file on demand. This reduces ty's peak memory usage by ~20-30%. The primary change of this PR is adding a `node_index` field to every AST node, that is assigned by the parser. `ParsedModule` can use this to create a flat index of AST nodes any time the file is parsed (or reparsed). This allows `AstNodeRef` to simply index into the current instance of the `ParsedModule`, instead of storing a pointer directly. The indices are somewhat hackily (using an atomic integer) assigned by the `parsed_module` query instead of by the parser directly. Assigning the indices in source-order in the (recursive) parser turns out to be difficult, and collecting the nodes during semantic indexing is impossible as `SemanticIndex` does not hold onto a specific `ParsedModuleRef`, which the pointers in the flat AST are tied to. This means that we have to do an extra AST traversal to assign and collect the nodes into a flat index, but the small performance impact (~3% on cold runs) seems worth it for the memory savings. Part of https://github.com/astral-sh/ty/issues/214.
		
			
				
	
	
		
			368 lines
		
	
	
	
		
			16 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
			
		
		
	
	
			368 lines
		
	
	
	
		
			16 KiB
		
	
	
	
		
			Text
		
	
	
	
	
	
| ---
 | |
| source: crates/ruff_python_parser/tests/fixtures.rs
 | |
| input_file: crates/ruff_python_parser/resources/valid/expressions/named.py
 | |
| ---
 | |
| ## AST
 | |
| 
 | |
| ```
 | |
| Module(
 | |
|     ModModule {
 | |
|         node_index: AtomicNodeIndex(..),
 | |
|         range: 0..157,
 | |
|         body: [
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 0..11,
 | |
|                     value: Named(
 | |
|                         ExprNamed {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 1..10,
 | |
|                             target: Name(
 | |
|                                 ExprName {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 1..5,
 | |
|                                     id: Name("name"),
 | |
|                                     ctx: Store,
 | |
|                                 },
 | |
|                             ),
 | |
|                             value: NumberLiteral(
 | |
|                                 ExprNumberLiteral {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 9..10,
 | |
|                                     value: Int(
 | |
|                                         0,
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 12..29,
 | |
|                     value: Named(
 | |
|                         ExprNamed {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 13..28,
 | |
|                             target: Name(
 | |
|                                 ExprName {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 13..17,
 | |
|                                     id: Name("name"),
 | |
|                                     ctx: Store,
 | |
|                                 },
 | |
|                             ),
 | |
|                             value: BinOp(
 | |
|                                 ExprBinOp {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 22..27,
 | |
|                                     left: Name(
 | |
|                                         ExprName {
 | |
|                                             node_index: AtomicNodeIndex(..),
 | |
|                                             range: 22..23,
 | |
|                                             id: Name("x"),
 | |
|                                             ctx: Load,
 | |
|                                         },
 | |
|                                     ),
 | |
|                                     op: Mult,
 | |
|                                     right: Name(
 | |
|                                         ExprName {
 | |
|                                             node_index: AtomicNodeIndex(..),
 | |
|                                             range: 26..27,
 | |
|                                             id: Name("y"),
 | |
|                                             ctx: Load,
 | |
|                                         },
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 30..45,
 | |
|                     value: Named(
 | |
|                         ExprNamed {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 31..44,
 | |
|                             target: Name(
 | |
|                                 ExprName {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 31..35,
 | |
|                                     id: Name("name"),
 | |
|                                     ctx: Store,
 | |
|                                 },
 | |
|                             ),
 | |
|                             value: BinOp(
 | |
|                                 ExprBinOp {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 39..44,
 | |
|                                     left: NumberLiteral(
 | |
|                                         ExprNumberLiteral {
 | |
|                                             node_index: AtomicNodeIndex(..),
 | |
|                                             range: 39..40,
 | |
|                                             value: Int(
 | |
|                                                 1,
 | |
|                                             ),
 | |
|                                         },
 | |
|                                     ),
 | |
|                                     op: Add,
 | |
|                                     right: NumberLiteral(
 | |
|                                         ExprNumberLiteral {
 | |
|                                             node_index: AtomicNodeIndex(..),
 | |
|                                             range: 43..44,
 | |
|                                             value: Int(
 | |
|                                                 1,
 | |
|                                             ),
 | |
|                                         },
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 46..63,
 | |
|                     value: Named(
 | |
|                         ExprNamed {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 47..62,
 | |
|                             target: Name(
 | |
|                                 ExprName {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 47..51,
 | |
|                                     id: Name("name"),
 | |
|                                     ctx: Store,
 | |
|                                 },
 | |
|                             ),
 | |
|                             value: Tuple(
 | |
|                                 ExprTuple {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 55..62,
 | |
|                                     elts: [
 | |
|                                         Starred(
 | |
|                                             ExprStarred {
 | |
|                                                 node_index: AtomicNodeIndex(..),
 | |
|                                                 range: 56..58,
 | |
|                                                 value: Name(
 | |
|                                                     ExprName {
 | |
|                                                         node_index: AtomicNodeIndex(..),
 | |
|                                                         range: 57..58,
 | |
|                                                         id: Name("x"),
 | |
|                                                         ctx: Load,
 | |
|                                                     },
 | |
|                                                 ),
 | |
|                                                 ctx: Load,
 | |
|                                             },
 | |
|                                         ),
 | |
|                                         Name(
 | |
|                                             ExprName {
 | |
|                                                 node_index: AtomicNodeIndex(..),
 | |
|                                                 range: 60..61,
 | |
|                                                 id: Name("y"),
 | |
|                                                 ctx: Load,
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ],
 | |
|                                     ctx: Load,
 | |
|                                     parenthesized: true,
 | |
|                                 },
 | |
|                             ),
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 64..90,
 | |
|                     value: Named(
 | |
|                         ExprNamed {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 65..89,
 | |
|                             target: Name(
 | |
|                                 ExprName {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 65..69,
 | |
|                                     id: Name("name"),
 | |
|                                     ctx: Store,
 | |
|                                 },
 | |
|                             ),
 | |
|                             value: If(
 | |
|                                 ExprIf {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 73..89,
 | |
|                                     test: BooleanLiteral(
 | |
|                                         ExprBooleanLiteral {
 | |
|                                             node_index: AtomicNodeIndex(..),
 | |
|                                             range: 78..82,
 | |
|                                             value: true,
 | |
|                                         },
 | |
|                                     ),
 | |
|                                     body: Name(
 | |
|                                         ExprName {
 | |
|                                             node_index: AtomicNodeIndex(..),
 | |
|                                             range: 73..74,
 | |
|                                             id: Name("x"),
 | |
|                                             ctx: Load,
 | |
|                                         },
 | |
|                                     ),
 | |
|                                     orelse: Name(
 | |
|                                         ExprName {
 | |
|                                             node_index: AtomicNodeIndex(..),
 | |
|                                             range: 88..89,
 | |
|                                             id: Name("y"),
 | |
|                                             ctx: Load,
 | |
|                                         },
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 91..112,
 | |
|                     value: Named(
 | |
|                         ExprNamed {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 92..111,
 | |
|                             target: Name(
 | |
|                                 ExprName {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 92..96,
 | |
|                                     id: Name("name"),
 | |
|                                     ctx: Store,
 | |
|                                 },
 | |
|                             ),
 | |
|                             value: Lambda(
 | |
|                                 ExprLambda {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 100..111,
 | |
|                                     parameters: Some(
 | |
|                                         Parameters {
 | |
|                                             range: 107..108,
 | |
|                                             node_index: AtomicNodeIndex(
 | |
|                                                 0,
 | |
|                                             ),
 | |
|                                             posonlyargs: [],
 | |
|                                             args: [
 | |
|                                                 ParameterWithDefault {
 | |
|                                                     range: 107..108,
 | |
|                                                     node_index: AtomicNodeIndex(..),
 | |
|                                                     parameter: Parameter {
 | |
|                                                         range: 107..108,
 | |
|                                                         node_index: AtomicNodeIndex(..),
 | |
|                                                         name: Identifier {
 | |
|                                                             id: Name("x"),
 | |
|                                                             range: 107..108,
 | |
|                                                             node_index: AtomicNodeIndex(..),
 | |
|                                                         },
 | |
|                                                         annotation: None,
 | |
|                                                     },
 | |
|                                                     default: None,
 | |
|                                                 },
 | |
|                                             ],
 | |
|                                             vararg: None,
 | |
|                                             kwonlyargs: [],
 | |
|                                             kwarg: None,
 | |
|                                         },
 | |
|                                     ),
 | |
|                                     body: Name(
 | |
|                                         ExprName {
 | |
|                                             node_index: AtomicNodeIndex(..),
 | |
|                                             range: 110..111,
 | |
|                                             id: Name("x"),
 | |
|                                             ctx: Load,
 | |
|                                         },
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 113..132,
 | |
|                     value: Named(
 | |
|                         ExprNamed {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 114..131,
 | |
|                             target: Name(
 | |
|                                 ExprName {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 114..118,
 | |
|                                     id: Name("name"),
 | |
|                                     ctx: Store,
 | |
|                                 },
 | |
|                             ),
 | |
|                             value: Yield(
 | |
|                                 ExprYield {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 123..130,
 | |
|                                     value: Some(
 | |
|                                         Name(
 | |
|                                             ExprName {
 | |
|                                                 node_index: AtomicNodeIndex(..),
 | |
|                                                 range: 129..130,
 | |
|                                                 id: Name("x"),
 | |
|                                                 ctx: Load,
 | |
|                                             },
 | |
|                                         ),
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|             Expr(
 | |
|                 StmtExpr {
 | |
|                     node_index: AtomicNodeIndex(..),
 | |
|                     range: 133..157,
 | |
|                     value: Named(
 | |
|                         ExprNamed {
 | |
|                             node_index: AtomicNodeIndex(..),
 | |
|                             range: 134..156,
 | |
|                             target: Name(
 | |
|                                 ExprName {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 134..138,
 | |
|                                     id: Name("name"),
 | |
|                                     ctx: Store,
 | |
|                                 },
 | |
|                             ),
 | |
|                             value: YieldFrom(
 | |
|                                 ExprYieldFrom {
 | |
|                                     node_index: AtomicNodeIndex(..),
 | |
|                                     range: 143..155,
 | |
|                                     value: Name(
 | |
|                                         ExprName {
 | |
|                                             node_index: AtomicNodeIndex(..),
 | |
|                                             range: 154..155,
 | |
|                                             id: Name("x"),
 | |
|                                             ctx: Load,
 | |
|                                         },
 | |
|                                     ),
 | |
|                                 },
 | |
|                             ),
 | |
|                         },
 | |
|                     ),
 | |
|                 },
 | |
|             ),
 | |
|         ],
 | |
|     },
 | |
| )
 | |
| ```
 |