language-servers/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff.git synced 2025-07-22 20:45:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3
ruff/crates/ruff_python_ast_integration_tests
History
Micha Reiser 5a876ed25e
Visit Identifier node as part of the SourceOrderVisitor (#17110) 
## Summary

I don't remember exactly when we made `Identifier` a node but it is now
considered a node (it implements `AnyNodeRef`, it has a range). However,
we never updated
the `SourceOrderVisitor` to visit identifiers because we never had a use
case for it and visiting new nodes can change how the formatter
associates comments (breaking change!).
This PR updates the `SourceOrderVisitor` to visit identifiers and
changes the formatter comment visitor to skip identifiers (updating the
visitor might be desired because it could help simplifying some comment
placement logic but this is out of scope for this PR).

## Test Plan

Tests, updated snapshot tests
2025-04-01 16:58:09 +02:00
..
src
tests Visit Identifier node as part of the SourceOrderVisitor (#17110) 2025-04-01 16:58:09 +02:00
Cargo.toml
README.md

README.md

Integration tests for ruff_python_ast

This crate includes integration tests for the ruff_python_ast crate.

The reason for having a separate crate is to avoid introducing a dev circular dependency between the ruff_python_parser crate and the ruff_python_ast crate.

This crate shouldn't include any code, only tests.

Reference: