ruff/crates/red_knot_python_semantic/resources at d54c19b9839dc02fff4610b1034e0c6a7c32a3ab - language-servers/ruff

mirror of https://github.com/astral-sh/ruff.git synced 2025-09-29 05:15:12 +00:00

History

Carl Meyer d54c19b983 [red-knot] remove CallOutcome::Cast variant (#15461 ) ## Summary Simplification follow-up to #15413. There's no need to have a dedicated `CallOutcome` variant for every known function, it's only necessary if the special-cased behavior of the known function includes emitting extra diagnostics. For `typing.cast`, there's no such need; we can use the regular `Callable` outcome variant, and update the return type according to the cast. (This is the same way we already handle `len`.) One reason to avoid proliferating unnecessary `CallOutcome` variants is that currently we have to explicitly add emitting call-binding diagnostics, for each outcome variant. So we were previously wrongly silencing any binding diagnostics on calls to `typing.cast`. Fixing this revealed a separate bug, that we were emitting a bogus error anytime more than one keyword argument mapped to a `kwargs` parameter. So this PR also adds test and fix for that bug. ## Test Plan Existing `cast` tests pass unchanged, added new test for `kwargs` bug.	2025-01-13 10:58:53 -08:00
..
mdtest	[red-knot] remove CallOutcome::Cast variant (#15461 )	2025-01-13 10:58:53 -08:00
README.md	[red-knot] document test framework (#13695 )	2024-10-10 12:02:01 -07:00

[red-knot] remove CallOutcome::Cast variant (#15461 )

## Summary

Simplification follow-up to #15413.

There's no need to have a dedicated `CallOutcome` variant for every
known function, it's only necessary if the special-cased behavior of the
known function includes emitting extra diagnostics. For `typing.cast`,
there's no such need; we can use the regular `Callable` outcome variant,
and update the return type according to the cast. (This is the same way
we already handle `len`.)

One reason to avoid proliferating unnecessary `CallOutcome` variants is
that currently we have to explicitly add emitting call-binding
diagnostics, for each outcome variant. So we were previously wrongly
silencing any binding diagnostics on calls to `typing.cast`. Fixing this
revealed a separate bug, that we were emitting a bogus error anytime
more than one keyword argument mapped to a `**kwargs` parameter. So this
PR also adds test and fix for that bug.

## Test Plan

Existing `cast` tests pass unchanged, added new test for `**kwargs` bug.

2025-01-13 10:58:53 -08:00

mdtest

[red-knot] remove CallOutcome::Cast variant (#15461 )

2025-01-13 10:58:53 -08:00

README.md

[red-knot] document test framework (#13695 )

2024-10-10 12:02:01 -07:00

README.md

Markdown files within the mdtest/ subdirectory are tests of type inference and type checking; executed by the tests/mdtest.rs integration test.

See crates/red_knot_test/README.md for documentation of this test format.