mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-29 13:25:17 +00:00
d9ac170eb4
<!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary Fix `E231` bug: Inconsistent catch compared to pycodestyle, such as when dict nested in list. Resolves #10113. ## Test Plan Example from #10113 added to test fixture.
106 lines
1.7 KiB
Python
106 lines
1.7 KiB
Python
#: E231
|
|
a = (1,2)
|
|
#: E231
|
|
a[b1,:]
|
|
#: E231
|
|
a = [{'a':''}]
|
|
#: Okay
|
|
a = (4,)
|
|
b = (5, )
|
|
c = {'text': text[5:]}
|
|
|
|
result = {
|
|
'key1': 'value',
|
|
'key2': 'value',
|
|
}
|
|
|
|
def foo() -> None:
|
|
#: E231
|
|
if (1,2):
|
|
pass
|
|
|
|
#: Okay
|
|
a = (1,\
|
|
2)
|
|
|
|
#: E231:2:20
|
|
mdtypes_template = {
|
|
'tag_full': [('mdtype', 'u4'), ('byte_count', 'u4')],
|
|
'tag_smalldata':[('byte_count_mdtype', 'u4'), ('data', 'S4')],
|
|
}
|
|
|
|
# E231
|
|
f"{(a,b)}"
|
|
|
|
# Okay because it's hard to differentiate between the usages of a colon in a f-string
|
|
f"{a:=1}"
|
|
f"{ {'a':1} }"
|
|
f"{a:.3f}"
|
|
f"{(a:=1)}"
|
|
f"{(lambda x:x)}"
|
|
f"normal{f"{a:.3f}"}normal"
|
|
|
|
#: Okay
|
|
snapshot.file_uri[len(f's3://{self.s3_bucket_name}/'):]
|
|
|
|
#: E231
|
|
{len(f's3://{self.s3_bucket_name}/'):1}
|
|
|
|
#: Okay
|
|
a = (1,)
|
|
|
|
|
|
# https://github.com/astral-sh/ruff/issues/10113
|
|
"""Minimal repo."""
|
|
|
|
def main() -> None:
|
|
"""Primary function."""
|
|
results = {
|
|
"k1": [1],
|
|
"k2":[2],
|
|
}
|
|
results_in_tuple = (
|
|
{
|
|
"k1": [1],
|
|
"k2":[2],
|
|
},
|
|
)
|
|
results_in_list = [
|
|
{
|
|
"k1": [1],
|
|
"k2":[2],
|
|
}
|
|
]
|
|
results_in_list_first = [
|
|
{
|
|
"k2":[2],
|
|
}
|
|
]
|
|
|
|
x = [
|
|
{
|
|
"k1":[2], # E231
|
|
"k2": [2:4],
|
|
"k3":[2], # E231
|
|
"k4": [2],
|
|
"k5": [2],
|
|
"k6": [1, 2, 3, 4,5,6,7] # E231
|
|
},
|
|
{
|
|
"k1": [
|
|
{
|
|
"ka":[2,3], # E231
|
|
},
|
|
{
|
|
"kb": [2,3], # E231
|
|
},
|
|
{
|
|
"ka":[2, 3], # E231
|
|
"kb": [2, 3], # Ok
|
|
"kc": [2, 3], # Ok
|
|
"kd": [2,3], # E231
|
|
"ke":[2,3], # E231
|
|
},
|
|
]
|
|
}
|
|
]
|