mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-29 21:35:58 +00:00
4454fbf7e5
## Summary
This PR fixes the bug where the rule `E251` was being triggered on a equal token
inside a f-string which was used in the context of debug expressions.
For example, the following was being flagged before the fix:
```python
print(f"{foo = }")
```
But, now it is not. This leads to false negatives such as:
```python
print(f"{foo(a = 1)}")
```
One solution would be to know if the opened parentheses was inside a f-string or
not. If it was then we can continue flagging until it's closed. If not, then we
should not flag it.
## Test Plan
Add new test cases and check that they don't raise any false positives.
fixes: #7882
61 lines
1.4 KiB
Python
61 lines
1.4 KiB
Python
#: E251 E251
|
|
def foo(bar = False):
|
|
'''Test function with an error in declaration'''
|
|
pass
|
|
#: E251
|
|
foo(bar= True)
|
|
#: E251
|
|
foo(bar =True)
|
|
#: E251 E251
|
|
foo(bar = True)
|
|
#: E251
|
|
y = bar(root= "sdasd")
|
|
#: E251:2:29
|
|
parser.add_argument('--long-option',
|
|
default=
|
|
"/rather/long/filesystem/path/here/blah/blah/blah")
|
|
#: E251:1:45
|
|
parser.add_argument('--long-option', default
|
|
="/rather/long/filesystem/path/here/blah/blah/blah")
|
|
#: E251:3:8 E251:3:10
|
|
foo(True,
|
|
baz=(1, 2),
|
|
biz = 'foo'
|
|
)
|
|
#: Okay
|
|
foo(bar=(1 == 1))
|
|
foo(bar=(1 != 1))
|
|
foo(bar=(1 >= 1))
|
|
foo(bar=(1 <= 1))
|
|
(options, args) = parser.parse_args()
|
|
d[type(None)] = _deepcopy_atomic
|
|
|
|
# Annotated Function Definitions
|
|
#: Okay
|
|
def munge(input: AnyStr, sep: AnyStr = None, limit=1000,
|
|
extra: Union[str, dict] = None) -> AnyStr:
|
|
pass
|
|
#: Okay
|
|
async def add(a: int = 0, b: int = 0) -> int:
|
|
return a + b
|
|
# Previously E251 four times
|
|
#: E271:1:6
|
|
async def add(a: int = 0, b: int = 0) -> int:
|
|
return a + b
|
|
#: E252:1:15 E252:1:16 E252:1:27 E252:1:36
|
|
def add(a: int=0, b: int =0, c: int= 0) -> int:
|
|
return a + b + c
|
|
#: Okay
|
|
def add(a: int = _default(name='f')):
|
|
return a
|
|
|
|
# F-strings
|
|
f"{a=}"
|
|
f"{a:=1}"
|
|
f"{foo(a=1)}"
|
|
f"normal {f"{a=}"} normal"
|
|
|
|
# Okay as the `=` is used inside a f-string...
|
|
print(f"{foo = }")
|
|
# ...but then it creates false negatives for now
|
|
print(f"{foo(a = 1)}")
|