ruff/crates/ruff_python_ast_integration_tests/tests/snapshots
Micha Reiser 5a876ed25e
Visit Identifier node as part of the SourceOrderVisitor (#17110)
## Summary

I don't remember exactly when we made `Identifier` a node but it is now
considered a node (it implements `AnyNodeRef`, it has a range). However,
we never updated
the `SourceOrderVisitor` to visit identifiers because we never had a use
case for it and visiting new nodes can change how the formatter
associates comments (breaking change!).
This PR updates the `SourceOrderVisitor` to visit identifiers and
changes the formatter comment visitor to skip identifiers (updating the
visitor might be desired because it could help simplifying some comment
placement logic but this is out of scope for this PR).

## Test Plan

Tests, updated snapshot tests
2025-04-01 16:58:09 +02:00
..
source_order__bytes_literals.snap
source_order__class_type_parameters.snap Visit Identifier node as part of the SourceOrderVisitor (#17110) 2025-04-01 16:58:09 +02:00
source_order__compare.snap
source_order__decorators.snap Visit Identifier node as part of the SourceOrderVisitor (#17110) 2025-04-01 16:58:09 +02:00
source_order__dict_comprehension.snap
source_order__f_strings.snap
source_order__function_arguments.snap Visit Identifier node as part of the SourceOrderVisitor (#17110) 2025-04-01 16:58:09 +02:00
source_order__function_positional_only_with_default.snap Visit Identifier node as part of the SourceOrderVisitor (#17110) 2025-04-01 16:58:09 +02:00
source_order__function_type_parameters.snap Visit Identifier node as part of the SourceOrderVisitor (#17110) 2025-04-01 16:58:09 +02:00
source_order__list_comprehension.snap
source_order__match_class_pattern.snap
source_order__set_comprehension.snap
source_order__string_literals.snap
source_order__type_aliases.snap Visit Identifier node as part of the SourceOrderVisitor (#17110) 2025-04-01 16:58:09 +02:00
visitor__bytes_literals.snap
visitor__class_type_parameters.snap
visitor__compare.snap
visitor__decorators.snap
visitor__dict_comprehension.snap
visitor__f_strings.snap
visitor__function_arguments.snap
visitor__function_positional_only_with_default.snap
visitor__function_type_parameters.snap
visitor__list_comprehension.snap
visitor__match_class_pattern.snap
visitor__set_comprehension.snap
visitor__string_literals.snap
visitor__type_aliases.snap