mirror of
https://github.com/astral-sh/ruff.git
synced 2025-11-01 04:18:05 +00:00
e474f36473
## Summary This PR fixes astral-sh/ty#185 by avoiding to infer the value expression for an unpacking. This is done simply by only inferring the value expression in a non-unpacking branch for assignment statement, for statement, with statement and comprehensions. This is a simpler alternative to https://github.com/astral-sh/ruff/pull/18890 which I only realized in hindsight! Ideally, the solution would to consider the "unpack" as it's own region and do all of the inference of every expressions involved in an unpacking inside the unpack query and then merge the results in the outer query. This would require access to the `Unpack` ingredient which is stored on the `Definition`. And, this would require create the said `Definition`s for all attributes and subscript expressions. It does simplify the target inference logic by streamlining it into a single `infer_target` method instead of the `infer_target`/`infer_target_impl` split. Additionally, #18890 also solves a couple of TODOs around raising errors around attribute / subscript assignment. ## Test Plan Update the existing test, go through a couple of ecosystem diagnostic. |
||
|---|---|---|
| .. | ||
| corpus | ||
| mdtest | ||
| primer | ||
| README.md | ||
Markdown files within the mdtest/ subdirectory are tests of type inference and type checking;
executed by the tests/mdtest.rs integration test.
See crates/ty_test/README.md for documentation of this test format.