mirror of
https://github.com/astral-sh/ruff.git
synced 2025-09-27 12:29:28 +00:00
c2750a59ab
# Summary We need to support CR line endings (as opposed to LF and CRLF line endings, which are already supported). They're rare, but they do appear in Python code, and we tend to panic on any file that uses them. Our `Locator` abstraction now supports CR line endings. However, Rust's `str#lines` implementation does _not_. This PR adds a `UniversalNewlineIterator` implementation that respects all of CR, LF, and CRLF line endings, and plugs it into most of the `.lines()` call sites. As an alternative design, it could be nice if we could leverage `Locator` for this. We've already computed all of the line endings, so we could probably iterate much more efficiently? # Test Plan Largely relying on automated testing, however, also ran over some known failure cases, like #3404. |
||
|---|---|---|
| .. | ||
| cst | ||
| format | ||
| snapshots | ||
| attachment.rs | ||
| cli.rs | ||
| context.rs | ||
| lib.rs | ||
| main.rs | ||
| newlines.rs | ||
| parentheses.rs | ||
| shared_traits.rs | ||
| trivia.rs | ||