mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-01 06:11:43 +00:00
b5e5271adf
## Summary This is a follow-up to #15726, #15778, and #15794 to preserve the triple quote and prefix flags in plain strings, bytestrings, and f-strings. I also added a `StringLiteralFlags::without_triple_quotes` method to avoid passing along triple quotes in rules like SIM905 where it might not make sense, as discussed [here](https://github.com/astral-sh/ruff/pull/15726#discussion_r1930532426). ## Test Plan Existing tests, plus many new cases in the `generator::tests::quote` test that should cover all combinations of quotes and prefixes, at least for simple string bodies. Closes #7799 when combined with #15694, #15726, #15778, and #15794. --------- Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
108 lines
2.2 KiB
Python
108 lines
2.2 KiB
Python
# setup
|
|
sep = ","
|
|
no_sep = None
|
|
|
|
# positives
|
|
"""
|
|
itemA
|
|
itemB
|
|
itemC
|
|
""".split()
|
|
|
|
"a,b,c,d".split(",")
|
|
"a,b,c,d".split(None)
|
|
"a,b,c,d".split(",", 1)
|
|
"a,b,c,d".split(None, 1)
|
|
"a,b,c,d".split(sep=",")
|
|
"a,b,c,d".split(sep=None)
|
|
"a,b,c,d".split(sep=",", maxsplit=1)
|
|
"a,b,c,d".split(sep=None, maxsplit=1)
|
|
"a,b,c,d".split(maxsplit=1, sep=",")
|
|
"a,b,c,d".split(maxsplit=1, sep=None)
|
|
"a,b,c,d".split(",", maxsplit=1)
|
|
"a,b,c,d".split(None, maxsplit=1)
|
|
"a,b,c,d".split(maxsplit=1)
|
|
"a,b,c,d".split(maxsplit=1.0)
|
|
"a,b,c,d".split(maxsplit=1)
|
|
"a,b,c,d".split(maxsplit=0)
|
|
"VERB AUX PRON ADP DET".split(" ")
|
|
' 1 2 3 '.split()
|
|
'1<>2<>3<4'.split('<>')
|
|
|
|
" a*a a*a a ".split("*", -1) # [" a", "a a", "a a "]
|
|
"".split() # []
|
|
"""
|
|
""".split() # []
|
|
" ".split() # []
|
|
"/abc/".split() # ["/abc/"]
|
|
("a,b,c"
|
|
# comment
|
|
.split()
|
|
) # ["a,b,c"]
|
|
("a,b,c"
|
|
# comment1
|
|
.split(",")
|
|
) # ["a", "b", "c"]
|
|
("a,"
|
|
# comment
|
|
"b,"
|
|
"c"
|
|
.split(",")
|
|
) # ["a", "b", "c"]
|
|
|
|
"hello "\
|
|
"world".split()
|
|
# ["hello", "world"]
|
|
|
|
# prefixes and isc
|
|
u"a b".split() # [u"a", u"b"]
|
|
r"a \n b".split() # [r"a", r"\n", r"b"]
|
|
("a " "b").split() # ["a", "b"]
|
|
"a " "b".split() # ["a", "b"]
|
|
u"a " "b".split() # [u"a", u"b"]
|
|
"a " u"b".split() # ["a", "b"]
|
|
u"a " r"\n".split() # [u"a", u"\\n"]
|
|
r"\n " u"\n".split() # [r"\n"]
|
|
r"\n " "\n".split() # [r"\n"]
|
|
"a " r"\n".split() # ["a", "\\n"]
|
|
|
|
"a,b,c".split(',', maxsplit=0) # ["a,b,c"]
|
|
"a,b,c".split(',', maxsplit=-1) # ["a", "b", "c"]
|
|
"a,b,c".split(',', maxsplit=-2) # ["a", "b", "c"]
|
|
"a,b,c".split(',', maxsplit=-0) # ["a,b,c"]
|
|
|
|
# negatives
|
|
|
|
# invalid values should not cause panic
|
|
"a,b,c,d".split(maxsplit="hello")
|
|
"a,b,c,d".split(maxsplit=-"hello")
|
|
|
|
# variable names not implemented
|
|
"a,b,c,d".split(sep)
|
|
"a,b,c,d".split(no_sep)
|
|
for n in range(3):
|
|
"a,b,c,d".split(",", maxsplit=n)
|
|
|
|
# f-strings not yet implemented
|
|
world = "world"
|
|
_ = f"{world}_hello_world".split("_")
|
|
|
|
hello = "hello_world"
|
|
_ = f"{hello}_world".split("_")
|
|
|
|
# split on bytes not yet implemented, much less frequent
|
|
b"TesT.WwW.ExamplE.CoM".split(b".")
|
|
|
|
# str.splitlines not yet implemented
|
|
"hello\nworld".splitlines()
|
|
"hello\nworld".splitlines(keepends=True)
|
|
"hello\nworld".splitlines(keepends=False)
|
|
|
|
|
|
# another positive demonstrating quote preservation
|
|
"""
|
|
"itemA"
|
|
'itemB'
|
|
'''itemC'''
|
|
"'itemD'"
|
|
""".split()
|