mirror of
https://github.com/astral-sh/ruff.git
synced 2025-10-28 10:50:26 +00:00
008bbfdf5a
Some checks are pending
CI / Determine changes (push) Waiting to run
CI / cargo fmt (push) Waiting to run
CI / cargo clippy (push) Blocked by required conditions
CI / cargo test (linux) (push) Blocked by required conditions
CI / cargo test (linux, release) (push) Blocked by required conditions
CI / cargo test (windows) (push) Blocked by required conditions
CI / cargo test (wasm) (push) Blocked by required conditions
CI / cargo build (release) (push) Waiting to run
CI / cargo build (msrv) (push) Blocked by required conditions
CI / cargo fuzz build (push) Blocked by required conditions
CI / fuzz parser (push) Blocked by required conditions
CI / test scripts (push) Blocked by required conditions
CI / ecosystem (push) Blocked by required conditions
CI / Fuzz for new ty panics (push) Blocked by required conditions
CI / cargo shear (push) Blocked by required conditions
CI / python package (push) Waiting to run
CI / pre-commit (push) Waiting to run
CI / mkdocs (push) Waiting to run
CI / formatter instabilities and black similarity (push) Blocked by required conditions
CI / test ruff-lsp (push) Blocked by required conditions
CI / check playground (push) Blocked by required conditions
CI / benchmarks-instrumented (push) Blocked by required conditions
CI / benchmarks-walltime (push) Blocked by required conditions
[ty Playground] Release / publish (push) Waiting to run
As of [this cpython PR](https://github.com/python/cpython/pull/135996), it is not allowed to concatenate t-strings with non-t-strings, implicitly or explicitly. Expressions such as `"foo" t"{bar}"` are now syntax errors. This PR updates some AST nodes and parsing to reflect this change. The structural change is that `TStringPart` is no longer needed, since, as in the case of `BytesStringLiteral`, the only possibilities are that we have a single `TString` or a vector of such (representing an implicit concatenation of t-strings). This removes a level of nesting from many AST expressions (which is what all the snapshot changes reflect), and simplifies some logic in the implementation of visitors, for example. The other change of note is in the parser. When we meet an implicit concatenation of string-like literals, we now count the number of t-string literals. If these do not exhaust the total number of implicitly concatenated pieces, then we emit a syntax error. To recover from this syntax error, we encode any t-string pieces as _invalid_ string literals (which means we flag them as invalid, record their range, and record the value as `""`). Note that if at least one of the pieces is an f-string we prefer to parse the entire string as an f-string; otherwise we parse it as a string. This logic is exactly the same as how we currently treat `BytesStringLiteral` parsing and error recovery - and carries with it the same pros and cons. Finally, note that I have not implemented any changes in the implementation of the formatter. As far as I can tell, none are needed. I did change a few of the fixtures so that we are always concatenating t-strings with t-strings. |
||
|---|---|---|
| .. | ||
| carriage_return | ||
| expression | ||
| fmt_on_off | ||
| fmt_skip | ||
| parentheses | ||
| pattern | ||
| range_formatting | ||
| statement | ||
| stub_files | ||
| .editorconfig | ||
| blank_line_before_class_docstring.options.json | ||
| blank_line_before_class_docstring.py | ||
| docstring.options.json | ||
| docstring.py | ||
| docstring_chaperones.py | ||
| docstring_code_examples.options.json | ||
| docstring_code_examples.py | ||
| docstring_code_examples_crlf.options.json | ||
| docstring_code_examples_crlf.py | ||
| docstring_code_examples_dynamic_line_width.options.json | ||
| docstring_code_examples_dynamic_line_width.py | ||
| docstring_newlines.py | ||
| docstring_non_visible_characters.py | ||
| docstring_tab_indentation.options.json | ||
| docstring_tab_indentation.py | ||
| empty_multiple_trailing_newlines.py | ||
| empty_now_newline.py | ||
| empty_trailing_newline.py | ||
| empty_whitespace.py | ||
| f-string-carriage-return-newline.py | ||
| form_feed.py | ||
| module_dangling_comment1.py | ||
| module_dangling_comment2.py | ||
| multiline_string_deviations.py | ||
| newlines.py | ||
| newlines.pyi | ||
| notebook_docstring.options.json | ||
| notebook_docstring.py | ||
| pattern_match_regression_brackets.py | ||
| preview.options.json | ||
| preview.py | ||
| quote_style.options.json | ||
| quote_style.py | ||
| skip_magic_trailing_comma.options.json | ||
| skip_magic_trailing_comma.py | ||
| tab_width.options.json | ||
| tab_width.py | ||
| trailing_comments.py | ||
| trivia.py | ||