language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-30 13:51:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Check more carefully for cases where a rename can't be done

Browse source 
Attempting to rename an element of a tuple field would previously
replace the type with the new name, which doesn't make sense; now it
fails instead.

The check is done in both `prepare_rename` and `rename` so that the case
is caught before the user is prompted for a new name. Some other
existing failure cases are also now additionally checked in
`prepare_rename`.
This commit is contained in:
Danny Zhu 2021-04-25 13:28:38 -07:00
parent 1b4defd240
commit 09fc5e1dd7
2 changed files with 105 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/ide/src/display/navigation_target.rs
View file

@ -20,7 +20,7 @@ use syntax::{
use crate::FileSymbol;
/// `NavigationTarget` represents and element in the editor's UI which you can
/// `NavigationTarget` represents an element in the editor's UI which you can
/// click on to navigate to a particular piece of code.
///
/// Typically, a `NavigationTarget` corresponds to some element in the source
@ -35,12 +35,10 @@ pub struct NavigationTarget {
/// Clients should use this range to answer "is the cursor inside the
/// element?" question.
pub full_range: TextRange,
/// A "most interesting" range withing the `full_range`.
/// A "most interesting" range within the `full_range`.
///
/// Typically, `full_range` is the whole syntax node, including doc
/// comments, and `focus_range` is the range of the identifier. "Most
/// interesting" range within the full range, typically the range of
/// identifier.
/// comments, and `focus_range` is the range of the identifier.
///
/// Clients should place the cursor on this range when navigating to this target.
pub focus_range: Option<TextRange>,