language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-01 06:11:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Handle coercion on binary operator RHS

Browse source
This commit is contained in:
Laurențiu Nicola 2021-08-21 17:54:45 +03:00
parent 3f4c515223
commit 104d6124d7
2 changed files with 20 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
crates/hir_ty/src/infer/expr.rs
View file

@ -679,7 +679,8 @@ impl<'a> InferenceContext<'a> {
let lhs_ty = self.infer_expr(*lhs, &lhs_expectation); let lhs_ty = self.infer_expr(*lhs, &lhs_expectation);
let lhs_ty = self.resolve_ty_shallow(&lhs_ty); let lhs_ty = self.resolve_ty_shallow(&lhs_ty);
let rhs_expectation = op::binary_op_rhs_expectation(*op, lhs_ty.clone()); let rhs_expectation = op::binary_op_rhs_expectation(*op, lhs_ty.clone());
let rhs_ty = self.infer_expr(*rhs, &Expectation::has_type(rhs_expectation)); let rhs_ty =
self.infer_expr_coerce(*rhs, &Expectation::has_type(rhs_expectation));
let rhs_ty = self.resolve_ty_shallow(&rhs_ty); let rhs_ty = self.resolve_ty_shallow(&rhs_ty);
let ret = op::binary_op_return_ty(*op, lhs_ty.clone(), rhs_ty.clone()); let ret = op::binary_op_return_ty(*op, lhs_ty.clone(), rhs_ty.clone());

18
crates/hir_ty/src/tests/coercion.rs
View file

@ -257,6 +257,24 @@ fn foo() {
); );
} }
#[test]
fn assign_coerce() {
check_no_mismatches(
r"
//- minicore: deref
struct String;
impl core::ops::Deref for String { type Target = str; }
fn g(_text: &str) {}
fn f(text: &str) {
let mut text = text;
let tmp = String;
text = &tmp;
g(text);
}
",
);
}
#[test] #[test]
fn coerce_fn_item_to_fn_ptr() { fn coerce_fn_item_to_fn_ptr() {
check_no_mismatches( check_no_mismatches(