Drive by lints

This commit is contained in:
kjeremy 2019-09-23 14:31:30 -04:00
parent 5063274959
commit 1808175f98
4 changed files with 4 additions and 4 deletions

View file

@ -19,7 +19,7 @@ pub struct AstEditor<N: AstNode> {
} }
impl<N: AstNode> AstEditor<N> { impl<N: AstNode> AstEditor<N> {
pub fn new(node: N) -> AstEditor<N> pub fn new(node: N) -> Self
where where
N: Clone, N: Clone,
{ {

View file

@ -29,7 +29,7 @@ pub(crate) fn fill_match_arms(mut ctx: AssistCtx<impl HirDatabase>) -> Option<As
ctx.add_action(AssistId("fill_match_arms"), "fill match arms", |edit| { ctx.add_action(AssistId("fill_match_arms"), "fill match arms", |edit| {
let variants = variant_list.variants(); let variants = variant_list.variants();
let arms = variants.into_iter().filter_map(build_pat).map(|pat| { let arms = variants.filter_map(build_pat).map(|pat| {
AstBuilder::<ast::MatchArm>::from_pieces( AstBuilder::<ast::MatchArm>::from_pieces(
iter::once(pat), iter::once(pat),
&AstBuilder::<ast::Expr>::unit(), &AstBuilder::<ast::Expr>::unit(),

View file

@ -749,7 +749,7 @@ impl Const {
db.const_data(self) db.const_data(self)
} }
pub fn name(&self, db: &impl HirDatabase) -> Option<Name> { pub fn name(self, db: &impl HirDatabase) -> Option<Name> {
self.data(db).name().cloned() self.data(db).name().cloned()
} }

View file

@ -122,7 +122,7 @@ impl FromSource for StructField {
.fields() .fields()
.into_iter() .into_iter()
.flat_map(|it| it.iter()) .flat_map(|it| it.iter())
.map(|(id, _)| StructField { parent: variant_def.clone(), id }) .map(|(id, _)| StructField { parent: variant_def, id })
.find(|f| f.source(db) == src) .find(|f| f.source(db) == src)
} }
} }