language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-30 05:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat(ide-completion): extra sugar auto-completion async fn ... in impl trait for async fn in trait that's defined in desugar form

Browse source
This commit is contained in:
Yunfei 2024-07-29 22:42:31 +08:00 • committed by Lukas Wirth
parent 8d1d5cdfc1
commit 18feb726be
2 changed files with 84 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

38
crates/ide-completion/src/completions/item_list/trait_impl.rs
View file

@ -210,7 +210,7 @@ fn add_function_impl(
ast::AssocItem::Fn(func) => func,
_ => unreachable!(),
};
// TODO: need `function_decl` that unwraps future in the return type
let function_decl = function_declaration(&transformed_fn, source.file_id.is_macro());
match ctx.config.snippet_cap {
Some(cap) => {
@ -225,6 +225,42 @@ fn add_function_impl(
item.add_to(acc, ctx.db);
}
}
eprint!("is_desugar_async: {}", func.is_desugar_async(ctx.db));
if func.is_desugar_async(ctx.db) {
let label = format_smolstr!(
"async fn {}({})",
fn_name.display(ctx.db),
if func.assoc_fn_params(ctx.db).is_empty() { "" } else { ".." }
);
let mut item = CompletionItem::new(completion_kind, replacement_range, label);
item.lookup_by(format!("async fn {}", fn_name.display(ctx.db)))
.set_documentation(func.docs(ctx.db))
.set_relevance(CompletionRelevance { is_item_from_trait: true, ..Default::default() });
if let Some(source) = ctx.sema.source(func) {
let assoc_item = ast::AssocItem::Fn(source.value);
if let Some(transformed_item) = get_transformed_assoc_item(ctx, assoc_item, impl_def) {
let transformed_fn = match transformed_item {
ast::AssocItem::Fn(func) => func,
_ => unreachable!(),
};
let function_decl =
function_declaration(&transformed_fn, source.file_id.is_macro());
match ctx.config.snippet_cap {
Some(cap) => {
let snippet = format!("{function_decl} {{\n $0\n}}");
item.snippet_edit(cap, TextEdit::replace(replacement_range, snippet));
}
None => {
let header = format!("{function_decl} {{");
item.text_edit(TextEdit::replace(replacement_range, header));
}
};
item.add_to(acc, ctx.db);
}
}
}
}
/// Transform a relevant associated item to inline generics from the impl, remove attrs and docs, etc.