language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-26 11:59:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Implement fix, add tests

Browse source
This commit is contained in:
Phil Ellison 2020-12-30 15:46:05 +00:00
parent 1316422a7c
commit 1ff860b93c
4 changed files with 66 additions and 55 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/hir/src/diagnostics.rs
View file

@ -7,12 +7,3 @@ pub use hir_ty::diagnostics::{
IncorrectCase, MismatchedArgCount, MissingFields, MissingMatchArms, MissingOkOrSomeInTailExpr,
NoSuchField, RemoveThisSemicolon, ReplaceFilterMapNextWithFindMap,
};
// PHIL:
// hir/src/diagnostics.rs - just pub uses the type from hir_ty::diagnostics (DONE)
// hir_ty/src/diagnostics.rs - defines the type (DONE)
// hir_ty/src/diagnostics.rs - plus a test (DONE) <--- one example found, need to copy the not-applicable tests from the assist version
// ide/src/diagnostics.rs - define handler for when this diagnostic is raised (DONE)
// ide/src/diagnostics/fixes.rs - pulls in type from hir, and impls DiagnosticWithFix (TODO)
// hir_ty/src/diagnostics/expr.rs - do the real work (TODO)