language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-03 07:04:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Auto merge of #16722 - mo8it:allocations, r=Veykril

Browse source 
Avoid some allocations

I went on a small `.clone()` hunting tour :D
This commit is contained in:
bors 2024-03-04 09:17:23 +00:00
commit 2074cc28de
6 changed files with 30 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

18
crates/rust-analyzer/src/cli/analysis_stats.rs
View file

@ -371,7 +371,7 @@ impl flags::AnalysisStats {
let parse = sema.parse(file_id);
let file_txt = db.file_text(file_id);
let path = vfs.file_path(file_id).as_path().unwrap().to_owned();
let path = vfs.file_path(file_id).as_path().unwrap();
for node in parse.syntax().descendants() {
let expr = match syntax::ast::Expr::cast(node.clone()) {
@ -446,7 +446,7 @@ impl flags::AnalysisStats {
edit.apply(&mut txt);
if self.validate_term_search {
std::fs::write(&path, txt).unwrap();
std::fs::write(path, txt).unwrap();
let res = ws.run_build_scripts(&cargo_config, &|_| ()).unwrap();
if let Some(err) = res.error() {
@ -495,7 +495,7 @@ impl flags::AnalysisStats {
}
// Revert file back to original state
if self.validate_term_search {
std::fs::write(&path, file_txt.to_string()).unwrap();
std::fs::write(path, file_txt.to_string()).unwrap();
}
bar.inc(1);
@ -1077,12 +1077,12 @@ fn location_csv_pat(db: &RootDatabase, vfs: &Vfs, sm: &BodySourceMap, pat_id: Pa
format!("{path},{}:{},{}:{}", start.line + 1, start.col, end.line + 1, end.col)
}
fn expr_syntax_range(
fn expr_syntax_range<'a>(
db: &RootDatabase,
vfs: &Vfs,
vfs: &'a Vfs,
sm: &BodySourceMap,
expr_id: ExprId,
) -> Option<(VfsPath, LineCol, LineCol)> {
) -> Option<(&'a VfsPath, LineCol, LineCol)> {
let src = sm.expr_syntax(expr_id);
if let Ok(src) = src {
let root = db.parse_or_expand(src.file_id);
@ -1098,12 +1098,12 @@ fn expr_syntax_range(
None
}
}
fn pat_syntax_range(
fn pat_syntax_range<'a>(
db: &RootDatabase,
vfs: &Vfs,
vfs: &'a Vfs,
sm: &BodySourceMap,
pat_id: PatId,
) -> Option<(VfsPath, LineCol, LineCol)> {
) -> Option<(&'a VfsPath, LineCol, LineCol)> {
let src = sm.pat_syntax(pat_id);
if let Ok(src) = src {
let root = db.parse_or_expand(src.file_id);

8
crates/rust-analyzer/src/global_state.rs
View file

@ -297,7 +297,7 @@ impl GlobalState {
let mut bytes = vec![];
let mut modified_rust_files = vec![];
for file in changed_files {
let vfs_path = &vfs.file_path(file.file_id);
let vfs_path = vfs.file_path(file.file_id);
if let Some(path) = vfs_path.as_path() {
let path = path.to_path_buf();
if reload::should_refresh_for_change(&path, file.kind()) {
@ -481,7 +481,7 @@ impl GlobalStateSnapshot {
}
pub(crate) fn anchored_path(&self, path: &AnchoredPathBuf) -> Url {
let mut base = self.vfs_read().file_path(path.anchor);
let mut base = self.vfs_read().file_path(path.anchor).clone();
base.pop();
let path = base.join(&path.path).unwrap();
let path = path.as_path().unwrap();
@ -489,7 +489,7 @@ impl GlobalStateSnapshot {
}
pub(crate) fn file_id_to_file_path(&self, file_id: FileId) -> vfs::VfsPath {
self.vfs_read().file_path(file_id)
self.vfs_read().file_path(file_id).clone()
}
pub(crate) fn cargo_target_for_crate_root(
@ -497,7 +497,7 @@ impl GlobalStateSnapshot {
crate_id: CrateId,
) -> Option<(&CargoWorkspace, Target)> {
let file_id = self.analysis.crate_root(crate_id).ok()?;
let path = self.vfs_read().file_path(file_id);
let path = self.vfs_read().file_path(file_id).clone();
let path = path.as_path()?;
self.workspaces.iter().find_map(|ws| match ws {
ProjectWorkspace::Cargo { cargo, .. } => {

4
crates/rust-analyzer/src/handlers/request.rs
View file

@ -2097,7 +2097,7 @@ pub(crate) fn fetch_dependency_list(
.into_iter()
.filter_map(|it| {
let root_file_path = state.file_id_to_file_path(it.root_file_id);
crate_path(root_file_path).and_then(to_url).map(|path| CrateInfoResult {
crate_path(&root_file_path).and_then(to_url).map(|path| CrateInfoResult {
name: it.name,
version: it.version,
path,
@ -2118,7 +2118,7 @@ pub(crate) fn fetch_dependency_list(
/// An `Option` value representing the path to the directory of the crate with the given
/// name, if such a crate is found. If no crate with the given name is found, this function
/// returns `None`.
fn crate_path(root_file_path: VfsPath) -> Option<VfsPath> {
fn crate_path(root_file_path: &VfsPath) -> Option<VfsPath> {
let mut current_dir = root_file_path.parent();
while let Some(path) = current_dir {
let cargo_toml_path = path.join("../Cargo.toml")?;