From 2290cc3cf393079d30c026249af27838cc2d4595 Mon Sep 17 00:00:00 2001
From: Victor Song <vms2@rice.edu>
Date: Wed, 4 Oct 2023 08:13:01 -0500
Subject: [PATCH] Pass target directory as flag instead of env variable

---
 crates/flycheck/src/lib.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/crates/flycheck/src/lib.rs b/crates/flycheck/src/lib.rs
index f0d2f79f63..c2ad2661eb 100644
--- a/crates/flycheck/src/lib.rs
+++ b/crates/flycheck/src/lib.rs
@@ -360,10 +360,6 @@ impl FlycheckActor {
                 let mut cmd = Command::new(command);
                 cmd.envs(extra_env);
 
-                if let Some(target_dir) = target_dir {
-                    cmd.env("CARGO_TARGET_DIR", target_dir);
-                }
-
                 match invocation_location {
                     InvocationLocation::Workspace => {
                         match invocation_strategy {
@@ -381,6 +377,10 @@ impl FlycheckActor {
                     }
                 }
 
+                if let Some(target_dir) = target_dir {
+                    cmd.arg("--target-dir").arg(target_dir);
+                }
+
                 (cmd, args)
             }
         };