Enable extra warnings required by rust-lang/rust

crates/rust-analyzer/src/bin/main.rs

@@ -1,6 +1,9 @@
 //! Driver for rust-analyzer.
 //!
 //! Based on cli flags, either spawns an LSP server, or runs a batch analysis
+
+#![warn(rust_2018_idioms, unused_lifetimes, semicolon_in_expressions_from_macros)]
+
 mod logger;
 mod rustc_wrapper;
 

crates/rust-analyzer/src/lib.rs

@@ -9,6 +9,8 @@
 //! The `cli` submodule implements some batch-processing analysis, primarily as
 //! a debugging aid.
 
+#![warn(rust_2018_idioms, unused_lifetimes, semicolon_in_expressions_from_macros)]
+
 pub mod cli;
 
 #[allow(unused)]

crates/rust-analyzer/tests/slow-tests/main.rs

@@ -8,6 +8,8 @@
 //! specific JSON shapes here -- there's little value in such tests, as we can't
 //! be sure without a real client anyway.
 
+#![warn(rust_2018_idioms, unused_lifetimes, semicolon_in_expressions_from_macros)]
+
 mod sourcegen;
 mod tidy;
 mod testdir;