address review feedback

crates/hir_ty/src/diagnostics/decl_check.rs

@@ -926,11 +926,6 @@ fn main() {
         fn CheckItWorksWithModAttr(BAD_NAME_HI: u8) {}
     }
 
-    trait BAD_TRAIT {
-        fn BAD_FUNCTION();
-        fn BadFunction();
-    }
-
     #[allow(non_snake_case, non_camel_case_types)]
     pub struct some_type {
         SOME_FIELD: u8,
@@ -996,7 +991,26 @@ impl T for U {
             }
 
         }
-}"#,
+    }
+    "#,
+        );
+    }
+
+    #[test]
+    #[ignore]
+    fn bug_traits_arent_checked() {
+        // FIXME: Traits and functions in traits aren't currently checked by
+        // r-a, even though rustc will complain about them.
+        check_diagnostics(
+            r#"
+    trait BAD_TRAIT {
+       // ^^^^^^^^^ Trait `BAD_TRAIT` should have CamelCase name, e.g. `BadTrait`
+        fn BAD_FUNCTION();
+        // ^^^^^^^^^^^^ Function `BAD_FUNCTION` should have snake_case name, e.g. `bad_function`
+        fn BadFunction();
+        // ^^^^^^^^^^^^ Function `BadFunction` should have snake_case name, e.g. `bad_function`
+    }
+    "#,
         );
     }