language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-29 13:25:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Merge #8099

Browse source 
8099: Document fields of `ModuleId` r=jonas-schievink a=jonas-schievink

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
This commit is contained in:
bors[bot] 2021-03-18 23:07:41 +00:00 • committed by GitHub
commit 26fdd17cc6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/hir_def/src/lib.rs
View file

@ -76,7 +76,11 @@ use stdx::impl_from;
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)]
pub struct ModuleId { pub struct ModuleId {
krate: CrateId, krate: CrateId,
/// If this `ModuleId` was derived from a `DefMap` for a block expression, this stores the
/// `BlockId` of that block expression. If `None`, this module is part of the crate-level
/// `DefMap` of `krate`.
block: Option<BlockId>, block: Option<BlockId>,
/// The module's ID in its originating `DefMap`.
pub local_id: LocalModuleId, pub local_id: LocalModuleId,
} }
@ -87,7 +91,7 @@ impl ModuleId {
db.block_def_map(block).unwrap_or_else(|| { db.block_def_map(block).unwrap_or_else(|| {
// NOTE: This should be unreachable - all `ModuleId`s come from their `DefMap`s, // NOTE: This should be unreachable - all `ModuleId`s come from their `DefMap`s,
// so the `DefMap` here must exist. // so the `DefMap` here must exist.
panic!("no `block_def_map` for `ModuleId` {:?}", self); unreachable!("no `block_def_map` for `ModuleId` {:?}", self);
}) })
} }
None => db.crate_def_map(self.krate), None => db.crate_def_map(self.krate),