language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-02 06:41:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Merge #10985

Browse source 
10985: minor: Remove unnecessary clones r=Veykril a=Veykril

bors r+

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
This commit is contained in:
bors[bot] 2021-12-11 14:32:29 +00:00 • committed by GitHub
commit 3137327182
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/ide_db/src/helpers/import_assets.rs
View file

@ -280,7 +280,7 @@ impl ImportAssets {
.into_iter()
.filter(|import| import.import_path.len() > 1)
.filter(|import| !scope_definitions.contains(&ScopeDef::from(import.item_to_import)))
.sorted_by_key(|import| import.import_path.clone())
.sorted_by(|a, b| a.import_path.cmp(&b.import_path))
.collect()
}
@ -309,9 +309,9 @@ fn path_applicable_imports(
current_crate,
path_candidate.name.clone(),
// FIXME: we could look up assoc items by the input and propose those in completion,
// but that requries more preparation first:
// but that requires more preparation first:
// * store non-trait assoc items in import_map to fully enable this lookup
// * ensure that does not degrade the performance (bencmark it)
// * ensure that does not degrade the performance (benchmark it)
// * write more logic to check for corresponding trait presence requirement (we're unable to flyimport multiple item right now)
// * improve the associated completion item matching and/or scoring to ensure no noisy completions appear
//