language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-01 06:11:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Work around for issue in vscode reporting a failure in request

Browse source 
vscode would report "A request has failed" when it got "Content modified"
message and this would cause a pop-up to appear. This works around the issue by
returning an "empty" response that vscode can ignore.
This commit is contained in:
Ville Penttinen 2019-02-27 12:49:04 +02:00
parent 4248b39993
commit 33cebe1724
2 changed files with 16 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/gen_lsp_server/src/msg.rs
View file

@ -120,6 +120,11 @@ impl RawResponse {
let error = RawResponseError { code, message, data: None };
RawResponse { id, result: None, error: Some(error) }
}
/// Returns an "empty" RawResponse
/// Empty response still has a value `()` in its `result` field.
pub fn empty(id: u64) -> RawResponse {
RawResponse { id, result: Some(to_value(&()).unwrap()), error: None }
}
}
impl RawNotification {

16
crates/ra_lsp_server/src/main_loop.rs
View file

@ -416,11 +416,17 @@ impl<'a> PoolDispatcher<'a> {
}
Err(e) => {
if is_canceled(&e) {
RawResponse::err(
id,
ErrorCode::ContentModified as i32,
"content modified".to_string(),
)
// FIXME: When https://github.com/Microsoft/vscode-languageserver-node/issues/457
// gets fixed, we can return the proper response.
// This works around the issue where "content modified" error would continuously
// show an message pop-up in VsCode
// RawResponse::err(
// id,
// ErrorCode::ContentModified as i32,
// "content modified".to_string(),
// )
RawResponse::empty(id)
} else {
RawResponse::err(
id,