language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-30 11:37:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Make proc_macro span's line & column 1-indexed, as documented

Browse source 
That is, make the fake number that we return 1 and not 0.
This commit is contained in:
Chayim Refael Friedman 2025-01-25 23:15:10 +02:00
parent d6bf619606
commit 3f2fb17042
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/proc-macro-srv/src/server_impl/rust_analyzer_span.rs
View file

@ -392,12 +392,12 @@ impl server::Span for RaSpanServer {
fn line(&mut self, _span: Self::Span) -> usize { fn line(&mut self, _span: Self::Span) -> usize {
// FIXME requires db to resolve line index, THIS IS NOT INCREMENTAL // FIXME requires db to resolve line index, THIS IS NOT INCREMENTAL
0 1
} }
fn column(&mut self, _span: Self::Span) -> usize { fn column(&mut self, _span: Self::Span) -> usize {
// FIXME requires db to resolve line index, THIS IS NOT INCREMENTAL // FIXME requires db to resolve line index, THIS IS NOT INCREMENTAL
0 1
} }
} }

4
crates/proc-macro-srv/src/server_impl/token_id.rs
View file

@ -291,11 +291,11 @@ impl server::Span for TokenIdServer {
} }
fn line(&mut self, _span: Self::Span) -> usize { fn line(&mut self, _span: Self::Span) -> usize {
0 1
} }
fn column(&mut self, _span: Self::Span) -> usize { fn column(&mut self, _span: Self::Span) -> usize {
0 1
} }
} }