language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-03 07:04:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Remove hover fallback in favor of ranged hover

Browse source
This commit is contained in:
Lukas Wirth 2023-01-20 16:36:24 +01:00
parent a542bd46bf
commit 4685b97f74
2 changed files with 27 additions and 131 deletions
Download patch file Download diff file Expand all files Collapse all files

104
crates/ide/src/hover/tests.rs
View file

@ -213,25 +213,6 @@ m!(ab$0c);
);
}
#[test]
fn hover_shows_type_of_an_expression() {
check(
r#"
pub fn foo() -> u32 { 1 }
fn main() {
let foo_test = foo()$0;
}
"#,
expect![[r#"
*foo()*
```rust
u32
```
"#]],
);
}
#[test]
fn hover_remove_markdown_if_configured() {
check_hover_no_markdown(
@ -239,12 +220,14 @@ fn hover_remove_markdown_if_configured() {
pub fn foo() -> u32 { 1 }
fn main() {
let foo_test = foo()$0;
let foo_test = foo$0();
}
"#,
expect![[r#"
*foo()*
u32
*foo*
test
pub fn foo() -> u32
"#]],
);
}
@ -304,33 +287,6 @@ fn main() { let foo_test = fo$0o(); }
"#]],
);
// Multiple candidates but results are ambiguous.
check(
r#"
//- /a.rs
pub fn foo() -> u32 { 1 }
//- /b.rs
pub fn foo() -> &str { "" }
//- /c.rs
pub fn foo(a: u32, b: u32) {}
//- /main.rs
mod a;
mod b;
mod c;
fn main() { let foo_test = fo$0o(); }
"#,
expect![[r#"
*foo*
```rust
{unknown}
```
"#]],
);
// Use literal `crate` in path
check(
r#"
@ -1194,33 +1150,19 @@ fn test_hover_through_func_in_macro_recursive() {
macro_rules! id_deep { ($($tt:tt)*) => { $($tt)* } }
macro_rules! id { ($($tt:tt)*) => { id_deep!($($tt)*) } }
fn bar() -> u32 { 0 }
fn foo() { let a = id!([0u32, bar($0)] ); }
fn foo() { let a = id!([0u32, bar$0()] ); }
"#,
expect![[r#"
*bar()*
```rust
u32
```
"#]],
);
}
*bar*
#[test]
fn test_hover_through_literal_string_in_macro() {
check(
r#"
macro_rules! arr { ($($tt:tt)*) => { [$($tt)*] } }
fn foo() {
let mastered_for_itunes = "";
let _ = arr!("Tr$0acks", &mastered_for_itunes);
}
"#,
expect![[r#"
*"Tracks"*
```rust
&str
```
"#]],
```rust
test
```
```rust
fn bar() -> u32
```
"#]],
);
}
@ -5655,30 +5597,18 @@ fn main() {
#[test]
fn hover_underscore_type() {
check(
check_hover_no_result(
r#"
fn main() {
let x: _$0 = 0;
}
"#,
expect![[r#"
*_*
```rust
{unknown}
```
"#]],
);
check(
check_hover_no_result(
r#"
fn main() {
let x: (_$0,) = (0,);
}
"#,
expect![[r#"
*_*
```rust
{unknown}
```
"#]],
);
}