Merge pull request #18836 from Veykril/push-kksuoxxptvty

fix: Be more permissive with completion resolve data
This commit is contained in:
Lukas Wirth 2025-01-06 10:37:01 +00:00 committed by GitHub
commit 47ee513fa4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions

View file

@ -1,5 +1,9 @@
//! rust-analyzer extensions to the LSP.
// Note when adding new resolve payloads, add a #[serde(default)] on boolean fields as some clients
// might strip `false` values from the JSON payload due to their reserialization logic turning false
// into null which will then cause them to be omitted in the resolve request. See https://github.com/rust-lang/rust-analyzer/issues/18767
#![allow(clippy::disallowed_types)]
use std::ops;
@ -829,6 +833,7 @@ pub struct CompletionResolveData {
pub version: Option<i32>,
#[serde(skip_serializing_if = "Option::is_none", default)]
pub trigger_character: Option<char>,
#[serde(default)]
pub for_ref: bool,
pub hash: String,
}