From c81560c628d542540748c0f78d127d957bb77b24 Mon Sep 17 00:00:00 2001 From: Lukas Wirth Date: Tue, 29 Jul 2025 08:31:08 +0200 Subject: [PATCH] fix: Do not require all rename definitions to be renameable --- crates/ide/src/rename.rs | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/crates/ide/src/rename.rs b/crates/ide/src/rename.rs index a07c647c2c..6c1d142c3b 100644 --- a/crates/ide/src/rename.rs +++ b/crates/ide/src/rename.rs @@ -35,13 +35,8 @@ pub(crate) fn prepare_rename( let syntax = source_file.syntax(); let res = find_definitions(&sema, syntax, position, &Name::new_symbol_root(sym::underscore))? - .map(|(frange, kind, def, _, _)| { - // ensure all ranges are valid - - if def.range_for_rename(&sema).is_none() { - bail!("No references found at position") - } - + .filter(|(_, _, def, _, _)| def.range_for_rename(&sema).is_some()) + .map(|(frange, kind, _, _, _)| { always!( frange.range.contains_inclusive(position.offset) && frange.file_id == position.file_id