language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-29 21:35:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Get rid of do-er antipattern

Browse source
This commit is contained in:
Igor Aleksanov 2020-11-03 10:33:13 +03:00
parent caf0fa20a7
commit 4d333ebb63
7 changed files with 100 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/completion/src/render/enum_variant.rs
View file

@ -9,8 +9,17 @@ use crate::{
render::{builder_ext::Params, RenderContext},
};
pub(crate) fn render_enum_variant<'a>(
ctx: RenderContext<'a>,
local_name: Option<String>,
variant: hir::EnumVariant,
path: Option<ModPath>,
) -> CompletionItem {
EnumVariantRender::new(ctx, local_name, variant, path).render()
}
#[derive(Debug)]
pub(crate) struct EnumVariantRender<'a> {
struct EnumVariantRender<'a> {
ctx: RenderContext<'a>,
name: String,
variant: hir::EnumVariant,
@ -21,7 +30,7 @@ pub(crate) struct EnumVariantRender<'a> {
}
impl<'a> EnumVariantRender<'a> {
pub(crate) fn new(
fn new(
ctx: RenderContext<'a>,
local_name: Option<String>,
variant: hir::EnumVariant,
@ -51,7 +60,7 @@ impl<'a> EnumVariantRender<'a> {
}
}
pub(crate) fn render(self) -> CompletionItem {
fn render(self) -> CompletionItem {
let mut builder = CompletionItem::new(
CompletionKind::Reference,
self.ctx.source_range(),