language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-29 13:25:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Get rid of do-er antipattern

Browse source
This commit is contained in:
Igor Aleksanov 2020-11-03 10:33:13 +03:00
parent caf0fa20a7
commit 4d333ebb63
7 changed files with 100 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/completion/src/render/function.rs
View file

@ -8,8 +8,16 @@ use crate::{
render::{builder_ext::Params, RenderContext},
};
pub(crate) fn render_fn<'a>(
ctx: RenderContext<'a>,
local_name: Option<String>,
fn_: hir::Function,
) -> CompletionItem {
FunctionRender::new(ctx, local_name, fn_).render()
}
#[derive(Debug)]
pub(crate) struct FunctionRender<'a> {
struct FunctionRender<'a> {
ctx: RenderContext<'a>,
name: String,
fn_: hir::Function,
@ -17,7 +25,7 @@ pub(crate) struct FunctionRender<'a> {
}
impl<'a> FunctionRender<'a> {
pub(crate) fn new(
fn new(
ctx: RenderContext<'a>,
local_name: Option<String>,
fn_: hir::Function,
@ -28,7 +36,7 @@ impl<'a> FunctionRender<'a> {
FunctionRender { ctx, name, fn_, ast_node }
}
pub(crate) fn render(self) -> CompletionItem {
fn render(self) -> CompletionItem {
let params = self.params();
CompletionItem::new(CompletionKind::Reference, self.ctx.source_range(), self.name.clone())
.kind(self.kind())