language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-27 12:29:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

replace todo with fixme

Browse source
This commit is contained in:
Aleksey Kladov 2019-03-23 10:53:48 +03:00
parent 2394a2ee35
commit 4fd8cfd6ad
29 changed files with 71 additions and 71 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/ra_parser/src/grammar/items/consts.rs
View file

@ -11,7 +11,7 @@ pub(super) fn const_def(p: &mut Parser, m: Marker) {
fn const_or_static(p: &mut Parser, m: Marker, kw: SyntaxKind, def: SyntaxKind) {
assert!(p.at(kw));
p.bump();
p.eat(MUT_KW); // TODO: validator to forbid const mut
p.eat(MUT_KW); // FIXME: validator to forbid const mut
name(p);
types::ascription(p);
if p.eat(EQ) {

2
crates/ra_parser/src/grammar/items/nominal.rs
View file

@ -15,7 +15,7 @@ pub(super) fn struct_def(p: &mut Parser, m: Marker, kind: SyntaxKind) {
}
L_CURLY => named_field_def_list(p),
_ => {
//TODO: special case `(` error message
//FIXME: special case `(` error message
p.error("expected `;` or `{`");
}
}

2
crates/ra_parser/src/grammar/items/traits.rs
View file

@ -49,7 +49,7 @@ pub(super) fn impl_block(p: &mut Parser) {
type_params::opt_type_param_list(p);
}
// TODO: never type
// FIXME: never type
// impl ! {}
// test impl_block_neg

4
crates/ra_parser/src/grammar/items/use_item.rs
View file

@ -21,7 +21,7 @@ fn use_tree(p: &mut Parser) {
// This does not handle cases such as `use some::path::*`
// N.B. in Rust 2015 `use *;` imports all from crate root
// however in Rust 2018 `use *;` errors: ('cannot glob-import all possible crates')
// TODO: Add this error (if not out of scope)
// FIXME: Add this error (if not out of scope)
// test use_star
// use *;
@ -33,7 +33,7 @@ fn use_tree(p: &mut Parser) {
// Parse `use ::*;`, which imports all from the crate root in Rust 2015
// This is invalid inside a use_tree_list, (e.g. `use some::path::{::*}`)
// but still parses and errors later: ('crate root in paths can only be used in start position')
// TODO: Add this error (if not out of scope)
// FIXME: Add this error (if not out of scope)
// In Rust 2018, it is always invalid (see above)
p.bump();
p.bump();

4
crates/ra_parser/src/parser.rs
View file

@ -121,7 +121,7 @@ impl<'t> Parser<'t> {
/// final tree.
pub(crate) fn bump_remap(&mut self, kind: SyntaxKind) {
if self.nth(0) == EOF {
// TODO: panic!?
// FIXME: panic!?
return;
}
self.do_bump(kind, 1);
@ -135,7 +135,7 @@ impl<'t> Parser<'t> {
}
/// Emit error with the `message`
/// TODO: this should be much more fancy and support
/// FIXME: this should be much more fancy and support
/// structured errors with spans and notes, like rustc
/// does.
pub(crate) fn error<T: Into<String>>(&mut self, message: T) {