language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-01 22:31:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Disable unqualified assoc items completion for now

Browse source
This commit is contained in:
Kirill Bulatov 2021-03-20 23:04:28 +02:00
parent 879432452d
commit 56a7d246d5
3 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/ide_db/src/helpers/import_assets.rs
View file

@ -256,7 +256,14 @@ fn path_applicable_imports(
sema,
current_crate,
path_candidate.name.clone(),
// unqualified assoc items are not valid syntax
// FIXME: we could look up assoc items by the input and propose those in completion,
// but that requries more preparation first:
// * store non-trait assoc items in import_map to fully enable this lookup
// * ensure that does not degrade the performance (bencmark it)
// * write more logic to check for corresponding trait presence requirement (we're unable to flyimport multiple item right now)
// * improve the associated completion item matching and/or scoring to ensure no noisy completions appear
//
// see also an ignored test under FIXME comment in the qualify_path.rs module
AssocItemSearch::Exclude,
Some(DEFAULT_QUERY_SEARCH_LIMIT),
)