language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-29 13:25:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

internal: completion PathKind is not optional

Browse source
This commit is contained in:
Lukas Wirth 2022-05-06 12:04:41 +02:00
parent dd3f5e0993
commit 57a9915c1f
12 changed files with 40 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/ide-completion/src/render/function.rs
View file

@ -197,10 +197,10 @@ fn should_add_parens(ctx: &CompletionContext) -> bool {
}
match ctx.path_context {
Some(PathCompletionCtx { kind: Some(PathKind::Expr), has_call_parens: true, .. }) => {
Some(PathCompletionCtx { kind: PathKind::Expr, has_call_parens: true, .. }) => {
return false
}
Some(PathCompletionCtx { kind: Some(PathKind::Use | PathKind::Type), .. }) => {
Some(PathCompletionCtx { kind: PathKind::Use | PathKind::Type, .. }) => {
cov_mark::hit!(no_parens_in_use_item);
return false;
}

2
crates/ide-completion/src/render/macro_.rs
View file

@ -35,7 +35,7 @@ fn render(
let needs_bang = match completion.path_context {
Some(PathCompletionCtx { kind, has_macro_bang, .. }) => {
is_fn_like && kind != Some(PathKind::Use) && !has_macro_bang
is_fn_like && kind != PathKind::Use && !has_macro_bang
}
_ => is_fn_like,
};