language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-10-01 06:11:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: Deprioritize completions of private but editable definitions

Browse source
This commit is contained in:
Lukas Wirth 2022-02-02 02:05:49 +01:00
parent d7a544e69a
commit 5c41f5d165
12 changed files with 120 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/ide_completion/src/render.rs
View file

@ -28,11 +28,15 @@ use crate::{
#[derive(Debug)]
pub(crate) struct RenderContext<'a> {
completion: &'a CompletionContext<'a>,
is_private_editable: bool,
}
impl<'a> RenderContext<'a> {
pub(crate) fn new(completion: &'a CompletionContext<'a>) -> RenderContext<'a> {
RenderContext { completion }
pub(crate) fn new(
completion: &'a CompletionContext<'a>,
is_private_editable: bool,
) -> RenderContext<'a> {
RenderContext { completion, is_private_editable }
}
fn snippet_cap(&self) -> Option<SnippetCap> {
@ -47,6 +51,10 @@ impl<'a> RenderContext<'a> {
self.completion.source_range()
}
fn completion_relevance(&self) -> CompletionRelevance {
CompletionRelevance { is_private_editable: self.is_private_editable, ..Default::default() }
}
fn is_deprecated(&self, def: impl HasAttrs) -> bool {
let attrs = def.attrs(self.db());
attrs.by_key("deprecated").exists() || attrs.by_key("rustc_deprecated").exists()
@ -582,6 +590,7 @@ fn main() { let _: m::Spam = S$0 }
),
is_local: false,
is_op_method: false,
is_private_editable: false,
exact_postfix_snippet_match: false,
},
trigger_call_info: true,
@ -603,6 +612,7 @@ fn main() { let _: m::Spam = S$0 }
),
is_local: false,
is_op_method: false,
is_private_editable: false,
exact_postfix_snippet_match: false,
},
},
@ -689,6 +699,7 @@ fn foo() { A { the$0 } }
),
is_local: false,
is_op_method: false,
is_private_editable: false,
exact_postfix_snippet_match: false,
},
},