language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-29 21:35:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

handle match auto-deref

Browse source
This commit is contained in:
Josh Mcguigan 2020-04-05 12:42:24 -07:00
parent 5b4316377b
commit 5fe608fb31
2 changed files with 45 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/ra_hir_ty/src/expr.rs
View file

@ -93,7 +93,16 @@ impl<'a, 'b> ExprValidator<'a, 'b> {
// of the match expression. If we had a InvalidMatchArmPattern
// diagnostic or similar we could raise that in an else
// block here.
if pat_ty == match_expr_ty {
//
// When comparing the types, we also have to consider that rustc
// will automatically de-reference the match expression type if
// necessary.
if pat_ty == match_expr_ty
|| match_expr_ty
.as_reference()
.map(|(match_expr_ty, _)| match_expr_ty == pat_ty)
.unwrap_or(false)
{
// If we had a NotUsefulMatchArm diagnostic, we could
// check the usefulness of each pattern as we added it
// to the matrix here.