language-servers/rust-analyzer
1
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer.git synced 2025-09-29 05:15:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix clippy::len_zero

Browse source
This commit is contained in:
Alan Du 2019-06-04 02:28:22 -04:00
parent 7bcd8d6290
commit 619a615298
3 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/ra_hir/src/path.rs
View file

@ -116,7 +116,7 @@ impl Path {
/// `true` if this path is just a standalone `self` /// `true` if this path is just a standalone `self`
pub fn is_self(&self) -> bool { pub fn is_self(&self) -> bool {
self.kind == PathKind::Self_ && self.segments.len() == 0 self.kind == PathKind::Self_ && self.segments.is_empty()
} }
/// If this path is a single identifier, like `foo`, return its name. /// If this path is a single identifier, like `foo`, return its name.
@ -140,7 +140,7 @@ impl GenericArgs {
args.push(GenericArg::Type(type_ref)); args.push(GenericArg::Type(type_ref));
} }
// lifetimes and assoc type args ignored for now // lifetimes and assoc type args ignored for now
if args.len() > 0 { if !args.is_empty() {
Some(GenericArgs { args }) Some(GenericArgs { args })
} else { } else {
None None

4
crates/ra_ide_api/src/line_index.rs
View file

@ -41,7 +41,7 @@ impl LineIndex {
newlines.push(curr_row); newlines.push(curr_row);
// Save any utf-16 characters seen in the previous line // Save any utf-16 characters seen in the previous line
if utf16_chars.len() > 0 { if !utf16_chars.is_empty() {
utf16_lines.insert(line, utf16_chars); utf16_lines.insert(line, utf16_chars);
utf16_chars = Vec::new(); utf16_chars = Vec::new();
} }
@ -61,7 +61,7 @@ impl LineIndex {
} }
// Save any utf-16 characters seen in the last line // Save any utf-16 characters seen in the last line
if utf16_chars.len() > 0 { if !utf16_chars.is_empty() {
utf16_lines.insert(line, utf16_chars); utf16_lines.insert(line, utf16_chars);
} }

2
crates/ra_mbe/src/syntax_bridge.rs
View file

@ -292,7 +292,7 @@ fn delim_to_str(d: tt::Delimiter, closing: bool) -> SmolStr {
}; };
let idx = closing as usize; let idx = closing as usize;
let text = if texts.len() > 0 { &texts[idx..texts.len() - (1 - idx)] } else { "" }; let text = if !texts.is_empty() { &texts[idx..texts.len() - (1 - idx)] } else { "" };
text.into() text.into()
} }